You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/20 03:37:29 UTC

[GitHub] [airflow] ad-m commented on a change in pull request #13187: [AIRFLOW-3723] Add Gzip capability to mongo_to_S3 operator

ad-m commented on a change in pull request #13187:
URL: https://github.com/apache/airflow/pull/13187#discussion_r546315768



##########
File path: airflow/providers/amazon/aws/hooks/s3.py
##########
@@ -515,6 +515,7 @@ def load_string(
         encrypt: bool = False,
         encoding: Optional[str] = None,
         acl_policy: Optional[str] = None,
+        gzip: bool = False,

Review comment:
       Why only gzip? zstd is also gaining more and more popularity and other algorithms may be developed in the future. Have you considered approaching the interface in a general way but implement one algorithm for now?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org