You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@apache.org> on 2016/04/08 19:44:09 UTC

Review Request 45933: Fix bug when checking to ensure that all db migrations on the classpath have been applied.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45933/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
-------

While testing applying the multiple migrations for storing images, I noticed that we were rolling one back on startup when no migration should be performed.

It turned out I misunderstood the semantics of the Java8 stream API filter/findFirst combination.


Diffs
-----

  config/checkstyle/suppressions.xml 30a32ce4d90f51295135c3fe6205777f8b2eb569 
  src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java e2b841631460b5414d3f95497930c23cacf1d3a6 
  src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java 5edc2ada26d9cc042f22342b6796a399722ccb0c 
  src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V002_TestMigration2.java PRE-CREATION 

Diff: https://reviews.apache.org/r/45933/diff/


Testing
-------

./gradlew build -Pq


Thanks,

Joshua Cohen

Re: Review Request 45933: Fix bug when checking to ensure that all db migrations on the classpath have been applied.

Posted by Joshua Cohen <jc...@apache.org>.

> On April 8, 2016, 6:39 p.m., Joshua Cohen wrote:
> > @ReviewBot retry

Looks like archive.apache.org is down for maintenance until Monday. Shipping this sans-ReviewBot's thumbs up.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45933/#review127840
-----------------------------------------------------------


On April 8, 2016, 5:44 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45933/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:44 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> While testing applying the multiple migrations for storing images, I noticed that we were rolling one back on startup when no migration should be performed.
> 
> It turned out I misunderstood the semantics of the Java8 stream API filter/findFirst combination.
> 
> 
> Diffs
> -----
> 
>   config/checkstyle/suppressions.xml 30a32ce4d90f51295135c3fe6205777f8b2eb569 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java e2b841631460b5414d3f95497930c23cacf1d3a6 
>   src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java 5edc2ada26d9cc042f22342b6796a399722ccb0c 
>   src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V002_TestMigration2.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45933/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 45933: Fix bug when checking to ensure that all db migrations on the classpath have been applied.

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45933/#review127840
-----------------------------------------------------------



@ReviewBot retry

- Joshua Cohen


On April 8, 2016, 5:44 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45933/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:44 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> While testing applying the multiple migrations for storing images, I noticed that we were rolling one back on startup when no migration should be performed.
> 
> It turned out I misunderstood the semantics of the Java8 stream API filter/findFirst combination.
> 
> 
> Diffs
> -----
> 
>   config/checkstyle/suppressions.xml 30a32ce4d90f51295135c3fe6205777f8b2eb569 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java e2b841631460b5414d3f95497930c23cacf1d3a6 
>   src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java 5edc2ada26d9cc042f22342b6796a399722ccb0c 
>   src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V002_TestMigration2.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45933/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 45933: Fix bug when checking to ensure that all db migrations on the classpath have been applied.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45933/#review127835
-----------------------------------------------------------



Master (5ecded7) is red with this patch.
  ./build-support/jenkins/build.sh

:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean UP-TO-DATE
:api:clean UP-TO-DATE
:buildSrc:clean UP-TO-DATE
:commons:clean UP-TO-DATE
:commons-args:clean UP-TO-DATE
:enforceVersion UP-TO-DATE
:api:generateThriftJava
make: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
sha256=$(curl -s --show-error https://archive.apache.org/dist/thrift/0.9.1/thrift-0.9.1.tar.gz | tee thrift-0.9.1.tar.gz | 	openssl dgst -sha256 | cut -d' ' -f2) && \
	[ "${sha256}" = "ac175080c8cac567b0331e394f23ac306472c071628396db2850cb00c41b0017" ] && \
	tar zxvf thrift-0.9.1.tar.gz && \
	cd thrift-0.9.1 && \
	sha256=$(curl -s --show-error https://issues.apache.org/jira/secure/attachment/12632477/yylex.patch | tee thrift.patch | 	openssl dgst -sha256 | cut -d' ' -f2) && \
	[ "${sha256}" = "70f20b4e5b2e004b8a0d075b80a52750bce5be02ed83efdc60adbc45ec386a6c" ] && \
	patch -p1 < thrift.patch && \
	./configure --disable-dependency-tracking --disable-shared --without-c_glib --without-cpp --without-csharp --without-d --without-erlang --without-go --without-java --without-haskell --without-perl --without-php --without-php_extension --without-pic --without-python --without-qt4 --without-ruby --without-tests && \
	make -j4
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
make: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:generateThriftJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw'' finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 41.146 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 8, 2016, 5:44 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45933/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:44 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> While testing applying the multiple migrations for storing images, I noticed that we were rolling one back on startup when no migration should be performed.
> 
> It turned out I misunderstood the semantics of the Java8 stream API filter/findFirst combination.
> 
> 
> Diffs
> -----
> 
>   config/checkstyle/suppressions.xml 30a32ce4d90f51295135c3fe6205777f8b2eb569 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java e2b841631460b5414d3f95497930c23cacf1d3a6 
>   src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java 5edc2ada26d9cc042f22342b6796a399722ccb0c 
>   src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V002_TestMigration2.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45933/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 45933: Fix bug when checking to ensure that all db migrations on the classpath have been applied.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45933/#review127822
-----------------------------------------------------------


Ship it!




Ship It!

- Maxim Khutornenko


On April 8, 2016, 5:44 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45933/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:44 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> While testing applying the multiple migrations for storing images, I noticed that we were rolling one back on startup when no migration should be performed.
> 
> It turned out I misunderstood the semantics of the Java8 stream API filter/findFirst combination.
> 
> 
> Diffs
> -----
> 
>   config/checkstyle/suppressions.xml 30a32ce4d90f51295135c3fe6205777f8b2eb569 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java e2b841631460b5414d3f95497930c23cacf1d3a6 
>   src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java 5edc2ada26d9cc042f22342b6796a399722ccb0c 
>   src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V002_TestMigration2.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45933/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 45933: Fix bug when checking to ensure that all db migrations on the classpath have been applied.

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45933/#review127825
-----------------------------------------------------------



Master (5ecded7) is red with this patch.
  ./build-support/jenkins/build.sh

:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean UP-TO-DATE
:api:clean UP-TO-DATE
:buildSrc:clean UP-TO-DATE
:commons:clean UP-TO-DATE
:commons-args:clean UP-TO-DATE
:enforceVersion UP-TO-DATE
:api:generateThriftJava
make: Entering directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
sha256=$(curl -s --show-error https://archive.apache.org/dist/thrift/0.9.1/thrift-0.9.1.tar.gz | tee thrift-0.9.1.tar.gz | 	openssl dgst -sha256 | cut -d' ' -f2) && \
	[ "${sha256}" = "ac175080c8cac567b0331e394f23ac306472c071628396db2850cb00c41b0017" ] && \
	tar zxvf thrift-0.9.1.tar.gz && \
	cd thrift-0.9.1 && \
	sha256=$(curl -s --show-error https://issues.apache.org/jira/secure/attachment/12632477/yylex.patch | tee thrift.patch | 	openssl dgst -sha256 | cut -d' ' -f2) && \
	[ "${sha256}" = "70f20b4e5b2e004b8a0d075b80a52750bce5be02ed83efdc60adbc45ec386a6c" ] && \
	patch -p1 < thrift.patch && \
	./configure --disable-dependency-tracking --disable-shared --without-c_glib --without-cpp --without-csharp --without-d --without-erlang --without-go --without-java --without-haskell --without-perl --without-php --without-php_extension --without-pic --without-python --without-qt4 --without-ruby --without-tests && \
	make -j4
make: *** [thrift-0.9.1/compiler/cpp/thrift] Error 1
make: Leaving directory `/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift'
:api:generateThriftJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':api:generateThriftJava'.
> Process 'command '/home/jenkins/jenkins-slave/workspace/AuroraBot/build-support/thrift/thriftw'' finished with non-zero exit value 2

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED

Total time: 1 mins 9.419 secs


I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On April 8, 2016, 5:44 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45933/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:44 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> While testing applying the multiple migrations for storing images, I noticed that we were rolling one back on startup when no migration should be performed.
> 
> It turned out I misunderstood the semantics of the Java8 stream API filter/findFirst combination.
> 
> 
> Diffs
> -----
> 
>   config/checkstyle/suppressions.xml 30a32ce4d90f51295135c3fe6205777f8b2eb569 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java e2b841631460b5414d3f95497930c23cacf1d3a6 
>   src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java 5edc2ada26d9cc042f22342b6796a399722ccb0c 
>   src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V002_TestMigration2.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45933/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Re: Review Request 45933: Fix bug when checking to ensure that all db migrations on the classpath have been applied.

Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45933/#review127832
-----------------------------------------------------------



@ReviewBot retry

- Joshua Cohen


On April 8, 2016, 5:44 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45933/
> -----------------------------------------------------------
> 
> (Updated April 8, 2016, 5:44 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> While testing applying the multiple migrations for storing images, I noticed that we were rolling one back on startup when no migration should be performed.
> 
> It turned out I misunderstood the semantics of the Java8 stream API filter/findFirst combination.
> 
> 
> Diffs
> -----
> 
>   config/checkstyle/suppressions.xml 30a32ce4d90f51295135c3fe6205777f8b2eb569 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java e2b841631460b5414d3f95497930c23cacf1d3a6 
>   src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java 5edc2ada26d9cc042f22342b6796a399722ccb0c 
>   src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V002_TestMigration2.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45933/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>