You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by johnmccabe <gi...@git.apache.org> on 2015/11/09 01:50:55 UTC
[GitHub] incubator-brooklyn pull request: added missing URI/URL to String c...
GitHub user johnmccabe opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/1009
added missing URI/URL to String coercions
Added coercions to handle cases where a String ConfigKey is being populated from URI/URL typed sensors. For example (where `url` is a `String`, and `main.uri` is a `URI`):
```
url: $brooklyn:component("tomcat").attributeWhenReady("main.uri")
```
*Note*: Brooklyn provided entities only use `URI`, have included `URL` for completeness.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnmccabe/incubator-brooklyn typecoercion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/1009.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1009
----
commit 48e19c300cfc570b0987d7dfb80f2dd29ac47b4d
Author: John McCabe <jo...@johnmccabe.net>
Date: 2015-11-09T00:23:10Z
added missing URI/URL to String coercions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: added missing URI/URL to String c...
Posted by johnmccabe <gi...@git.apache.org>.
Github user johnmccabe commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1009#discussion_r44265971
--- Diff: core/src/test/java/org/apache/brooklyn/util/core/internal/TypeCoercionsTest.java ---
@@ -20,9 +20,13 @@
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertNull;
+import static org.testng.Assert.fail;
--- End diff --
Fixed and squashed, thanks @neykov
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: added missing URI/URL to String c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/1009
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: added missing URI/URL to String c...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/1009#issuecomment-155051182
Thanks @johnmccabe, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: added missing URI/URL to String c...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/1009#discussion_r44262841
--- Diff: core/src/test/java/org/apache/brooklyn/util/core/internal/TypeCoercionsTest.java ---
@@ -20,9 +20,13 @@
import static org.testng.Assert.assertEquals;
import static org.testng.Assert.assertNull;
+import static org.testng.Assert.fail;
--- End diff --
This one doesn't seem to be used, otherwise perfect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---