[GitHub] [spark] HeartSaVioR commented on a diff in pull request #38911: [SPARK-41387][SS] Assert current end offset from Kafka data source for Trigger.AvailableNow

[GitBox <gi...@apache.org>]

HeartSaVioR commented on code in PR #38911:
URL: https://github.com/apache/spark/pull/38911#discussion_r1041067010


##########
connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaSource.scala:
##########
@@ -349,6 +354,54 @@ private[kafka010] class KafkaSource(
     }
   }
 
+  private def assertEndOffsetForTriggerAvailableNow(

Review Comment:
   In the end we want to remove DSv1 implementation of Kafka data source. (There is a semantic issue on batch side.) Till that time, I'd like to duplicate code, like we have been doing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org