You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2016/03/08 09:06:02 UTC
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated March 8, 2016, 1:35 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd01372e2d8c76d98e83989d952e3dc0779
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b8b6db94ccbad408415f23fa9aba6711c3d4e291
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8d6105f7a0917d9b625b4573807fdafa9fbeea6e
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c68d751358460814b64214675595b812e8f
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java f9d7457facbf5fe42050fdf76448d6344f4eda67
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java cd20fef09468891af5c18aac2a20f71be30afd77
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java f4225439ed50b1bb10d9512423e19749f6383664
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFileSerdeFormatter.java e40d0c2a09490719ff3bc4cd1abb01ebeb3a8742
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a7aecb31d2a497811afeb58b900c5f73df
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a006d6a69b396aad9733593c9a6d383fc24
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
lens-server/src/test/java/org/apache/lens/server/auth/FooBarAuthenticationProvider.java d4c3a838be8364689a0c69898b95387a5bb905a0
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 3b091f5ea576eb72ae473e060bbb5b3bef95f106
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-server/src/test/resources/lens-site.xml b5b3220be8eb9fc6c6ed488e274e198e91991f6a
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml 06cae12bbf64495bf1f17eca83fc7877b9441107
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On April 19, 2016, 6:54 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 820
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350455#file1350455line820>
> >
> > why did we remove the other condition?
In test cases we're using one `Configuration` object and the first query that uses that configuration has `mapred.job.priority` set inside the configuration. Subsequent queries use that priority and don't set priority again, hence fail in assertions.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129520
-----------------------------------------------------------
On April 19, 2016, 6:19 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:19 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On April 19, 2016, 6:54 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 820
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350455#file1350455line820>
> >
> > why did we remove the other condition?
>
> Rajat Khandelwal wrote:
> In test cases we're using one `Configuration` object and the first query that uses that configuration has `mapred.job.priority` set inside the configuration. Subsequent queries use that priority and don't set priority again, hence fail in assertions.
>
> Amareshwari Sriramadasu wrote:
> Can you check it again? The conf check is on ctx.getDriverConf(this) which should have been different for each context.
My bad, this was failing since we're trying to decide priority on the same context. Changed test code.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129520
-----------------------------------------------------------
On April 19, 2016, 6:19 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:19 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On April 19, 2016, 1:24 p.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 820
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350455#file1350455line820>
> >
> > why did we remove the other condition?
>
> Rajat Khandelwal wrote:
> In test cases we're using one `Configuration` object and the first query that uses that configuration has `mapred.job.priority` set inside the configuration. Subsequent queries use that priority and don't set priority again, hence fail in assertions.
Can you check it again? The conf check is on ctx.getDriverConf(this) which should have been different for each context.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129520
-----------------------------------------------------------
On April 19, 2016, 12:49 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 12:49 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129520
-----------------------------------------------------------
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 814)
<https://reviews.apache.org/r/41794/#comment192948>
why did we remove the other condition?
- Amareshwari Sriramadasu
On April 19, 2016, 12:49 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 12:49 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On April 29, 2016, 1:54 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java, line 64
> > <https://reviews.apache.org/r/41794/diff/9/?file=1364349#file1364349line64>
> >
> > Why did we remove immutable.copyof
Hitting some issue, had not investigated earlier. Did an investigation and found some issue with mocking. So a minor change in this solves the issue. Where ImmutableMap was being mocked, now it's being instantiated.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review131052
-----------------------------------------------------------
On April 29, 2016, 5:27 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 5:27 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975eafce851bf2bd11c659c2fc5971877305c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java 8a602248a7eacd26838fc6327a4c3a68a337d336
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review131052
-----------------------------------------------------------
Fix it, then Ship it!
Overall, looks good.
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java (line 63)
<https://reviews.apache.org/r/41794/#comment195006>
Why did we remove immutable.copyof
pom.xml (line 48)
<https://reviews.apache.org/r/41794/#comment195005>
Let us move to released version before shipping
- Amareshwari Sriramadasu
On April 28, 2016, 7:05 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 7:05 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On May 2, 2016, 7:33 p.m., Raju Bairishetti wrote:
> > lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java, line 110
> > <https://reviews.apache.org/r/41794/diff/10/?file=1365794#file1365794line110>
> >
> > I think we should not ignore Exceptions here as it may ended up resulting partial/empty results.
Fixed. Checking for `startsWith('.')` now
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review131310
-----------------------------------------------------------
On May 4, 2016, 6:14 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated May 4, 2016, 6:14 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 1dd2ffe129d6cf4c1d632dacf529d6dd9fa56990
> lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975eafce851bf2bd11c659c2fc5971877305c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java 8a602248a7eacd26838fc6327a4c3a68a337d336
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Raju Bairishetti <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review131310
-----------------------------------------------------------
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java (line 110)
<https://reviews.apache.org/r/41794/#comment195246>
I think we should not ignore Exceptions here as it may ended up resulting partial/empty results.
- Raju Bairishetti
On April 29, 2016, 11:57 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 11:57 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975eafce851bf2bd11c659c2fc5971877305c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java 8a602248a7eacd26838fc6327a4c3a68a337d336
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated May 9, 2016, 3:09 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 1dd2ffe129d6cf4c1d632dacf529d6dd9fa56990
lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1f6b66c0c7300dc8406f18ca23d2eddafc9ffc56
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java bc4f2a1262b89b83128a088de1d7245cedf085b7
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java e23290f6d56e46c0fc0887620eb76e838b4b70d4
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java 8a602248a7eacd26838fc6327a4c3a68a337d336
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java e71b507951c662dbdcd2875de730ec2a95a8b7a4
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java 51344ce9976a310b5eb66ff526eceef364e80700
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 34937090ca087af207ff7b443b90c5f64b2a3439
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
src/site/apt/admin/deployment.apt b4f4d0afa03e4b22edc0f83587fd8ad09effc99c
src/site/apt/developer/contribute.apt d1fea00d0afcbe6e0cd939bf23984e36d64d43a3
src/site/apt/lenshome/install-and-run.apt 961d926412758bb1a236bf0af90767f3a2f1b7a0
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated May 9, 2016, 1:12 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 1dd2ffe129d6cf4c1d632dacf529d6dd9fa56990
lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 1f6b66c0c7300dc8406f18ca23d2eddafc9ffc56
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java bc4f2a1262b89b83128a088de1d7245cedf085b7
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java e23290f6d56e46c0fc0887620eb76e838b4b70d4
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java 8a602248a7eacd26838fc6327a4c3a68a337d336
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java e71b507951c662dbdcd2875de730ec2a95a8b7a4
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java 51344ce9976a310b5eb66ff526eceef364e80700
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 34937090ca087af207ff7b443b90c5f64b2a3439
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
src/site/apt/admin/deployment.apt b4f4d0afa03e4b22edc0f83587fd8ad09effc99c
src/site/apt/developer/contribute.apt d1fea00d0afcbe6e0cd939bf23984e36d64d43a3
src/site/apt/lenshome/install-and-run.apt 961d926412758bb1a236bf0af90767f3a2f1b7a0
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated May 8, 2016, 3 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 1dd2ffe129d6cf4c1d632dacf529d6dd9fa56990
lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975eafce851bf2bd11c659c2fc5971877305c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java 8a602248a7eacd26838fc6327a4c3a68a337d336
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java 51344ce9976a310b5eb66ff526eceef364e80700
lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLRunner.java 34937090ca087af207ff7b443b90c5f64b2a3439
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated May 4, 2016, 6:14 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 1dd2ffe129d6cf4c1d632dacf529d6dd9fa56990
lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975eafce851bf2bd11c659c2fc5971877305c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java 8a602248a7eacd26838fc6327a4c3a68a337d336
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated May 4, 2016, 5:22 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java 1dd2ffe129d6cf4c1d632dacf529d6dd9fa56990
lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975eafce851bf2bd11c659c2fc5971877305c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java 8a602248a7eacd26838fc6327a4c3a68a337d336
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated April 29, 2016, 5:27 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975eafce851bf2bd11c659c2fc5971877305c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java 8a602248a7eacd26838fc6327a4c3a68a337d336
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated April 28, 2016, 12:35 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated April 21, 2016, 4:37 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 0773005d3376b23e96eb7274d5799ef9b44bc80e
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On April 21, 2016, 5 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java, line 259
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350481#file1350481line259>
> >
> > Why is session classloader used here? DB class loader should be independent of session class loader
>
> Rajat Khandelwal wrote:
> LensSessionImpl has this:
>
> ```
> ClassLoader classLoader = getClassLoader(getCurrentDatabase());
> Thread.currentThread().setContextClassLoader(classLoader);
> SessionState.getSessionConf().setClassLoader(classLoader);
> ```
>
> and `getClassLoader` is asking the db resource service for a classloader. So it's not just a db jars' classloader, it's the session's classloader and also will be used for further operations in the current thread.
Current change put up which is chaging db classloader - looks wrong to me.
> On April 21, 2016, 5 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, line 126
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350480#file1350480line126>
> >
> > Can you update unit tests for the changes done here?
>
> Rajat Khandelwal wrote:
> All existing tests are working. Should be enough.
>
> This is finding start location of `select` clause, earlier logic was to go back one "distinct" and one "select", now in case of `case` statements, the cursor location is at `when`. I didn't want to go back one `case`, one `distinct` and one `select`. Instead changed logic to go back untill a `select` is found.
Can we add test for case when statement?
> On April 21, 2016, 5 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 696
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350455#file1350455line696>
> >
> > Can we add test for this?
>
> Rajat Khandelwal wrote:
> How should I test this? The function is iterating and just doing `log.info...` for the lines. No return value.
We can add logback config to put the status logs in one more file. and read the file and assert. You can look at TestLogResource as an example.
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129854
-----------------------------------------------------------
On April 21, 2016, 11:07 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 11:07 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 0773005d3376b23e96eb7274d5799ef9b44bc80e
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 696
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350455#file1350455line696>
> >
> > Can we add test for this?
>
> Rajat Khandelwal wrote:
> How should I test this? The function is iterating and just doing `log.info...` for the lines. No return value.
>
> Amareshwari Sriramadasu wrote:
> We can add logback config to put the status logs in one more file. and read the file and assert. You can look at TestLogResource as an example.
Couldn't figure out an elegent way, Added in hive driver cleanup which checks whether there are any "Updates from Hive"
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java, line 259
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350481#file1350481line259>
> >
> > Why is session classloader used here? DB class loader should be independent of session class loader
>
> Rajat Khandelwal wrote:
> LensSessionImpl has this:
>
> ```
> ClassLoader classLoader = getClassLoader(getCurrentDatabase());
> Thread.currentThread().setContextClassLoader(classLoader);
> SessionState.getSessionConf().setClassLoader(classLoader);
> ```
>
> and `getClassLoader` is asking the db resource service for a classloader. So it's not just a db jars' classloader, it's the session's classloader and also will be used for further operations in the current thread.
>
> Amareshwari Sriramadasu wrote:
> Current change put up which is chaging db classloader - looks wrong to me.
Removed the changes, the changes of `LensSessionImpl` are ratained.
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, line 232
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350473#file1350473line232>
> >
> > Why is the scope change?
>
> Rajat Khandelwal wrote:
> TestHiveDriver uses this now. In some places I needed to give mergeDriverConf as false, since if it's true, then sometimes the query's driver conf has a value for `hive.in.test`, which is not allowed to be chaned at runtime.
QueryContext and related classes now checked out from master.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129854
-----------------------------------------------------------
On April 28, 2016, 12:35 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 12:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129854
-----------------------------------------------------------
On April 28, 2016, 12:35 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 12:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129854
-----------------------------------------------------------
On April 28, 2016, 12:35 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 12:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, line 696
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350455#file1350455line696>
> >
> > Can we add test for this?
How should I test this? The function is iterating and just doing `log.info...` for the lines. No return value.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129854
-----------------------------------------------------------
On April 21, 2016, 4:37 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 21, 2016, 4:37 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 0773005d3376b23e96eb7274d5799ef9b44bc80e
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, line 230
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350438#file1350438line230>
> >
> > Is the comment valid any more? If not, Should we remove the following line?
Sure. Now that we'll be depending on hive2, we can remove this.
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java, line 253
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350460#file1350460line253>
> >
> > Why is the change from driverConf to configuration?
This configuration object gets translated to a Map<String, String> and all those values are overlayed in the session one by one. Using HiveConf brings a lot more values and some of the values can not be set at runtime (e.g. `hive.in.test`)
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, line 232
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350473#file1350473line232>
> >
> > Why is the scope change?
TestHiveDriver uses this now. In some places I needed to give mergeDriverConf as false, since if it's true, then sometimes the query's driver conf has a value for `hive.in.test`, which is not allowed to be chaned at runtime.
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java, line 259
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350481#file1350481line259>
> >
> > Why is session classloader used here? DB class loader should be independent of session class loader
LensSessionImpl has this:
```
ClassLoader classLoader = getClassLoader(getCurrentDatabase());
Thread.currentThread().setContextClassLoader(classLoader);
SessionState.getSessionConf().setClassLoader(classLoader);
```
and `getClassLoader` is asking the db resource service for a classloader. So it's not just a db jars' classloader, it's the session's classloader and also will be used for further operations in the current thread.
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java, line 126
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350480#file1350480line126>
> >
> > Can you update unit tests for the changes done here?
All existing tests are working. Should be enough.
This is finding start location of `select` clause, earlier logic was to go back one "distinct" and one "select", now in case of `case` statements, the cursor location is at `when`. I didn't want to go back one `case`, one `distinct` and one `select`. Instead changed logic to go back untill a `select` is found.
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java, line 545
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350459#file1350459line545>
> >
> > Hope this change is done in result formatter as well.
Is added in FilePersistentFormatter.
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java, line 100
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350460#file1350460line100>
> >
> > This would need configuration changes in production as well. right?
No. There's a default unit.
retryDelaySeconds = (int) conf.getTimeVar(HiveConf.ConfVars.HIVE_SERVER2_THRIFT_CLIENT_RETRY_DELAY_SECONDS, TimeUnit.SECONDS);
> On April 21, 2016, 10:30 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java, line 943
> > <https://reviews.apache.org/r/41794/diff/7/?file=1350478#file1350478line943>
> >
> > Is it required any more?
Removed
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129854
-----------------------------------------------------------
On April 19, 2016, 6:19 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 6:19 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129854
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 230)
<https://reviews.apache.org/r/41794/#comment193392>
Is the comment valid any more? If not, Should we remove the following line?
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java (line 561)
<https://reviews.apache.org/r/41794/#comment193393>
Can you add unit test in TestHQLParser?
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 690)
<https://reviews.apache.org/r/41794/#comment193395>
Can we add test for this?
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java (line 541)
<https://reviews.apache.org/r/41794/#comment193397>
Hope this change is done in result formatter as well.
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java (line 100)
<https://reviews.apache.org/r/41794/#comment193396>
This would need configuration changes in production as well. right?
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java (line 252)
<https://reviews.apache.org/r/41794/#comment193398>
Why is the change from driverConf to configuration?
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java (line 228)
<https://reviews.apache.org/r/41794/#comment193399>
Why is the scope change?
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 943)
<https://reviews.apache.org/r/41794/#comment193400>
Is it required any more?
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 899)
<https://reviews.apache.org/r/41794/#comment193401>
We should call ctx.getLogHandle() instead of handle.getHandleString()
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java (line 126)
<https://reviews.apache.org/r/41794/#comment193402>
Can you update unit tests for the changes done here?
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 259)
<https://reviews.apache.org/r/41794/#comment193403>
Why is session classloader used here? DB class loader should be independent of session class loader
pom.xml (line 1636)
<https://reviews.apache.org/r/41794/#comment193391>
Can you define the version numbers as properties?
- Amareshwari Sriramadasu
On April 19, 2016, 12:49 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 12:49 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated April 19, 2016, 6:19 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review129497
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 1151)
<https://reviews.apache.org/r/41794/#comment192939>
Shouldnt this be part of HQLParser?
- Amareshwari Sriramadasu
On April 18, 2016, 12:36 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 18, 2016, 12:36 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated April 18, 2016, 6:06 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-es/src/test/resources/logback.xml PRE-CREATION
lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated April 15, 2016, 3:44 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 17, 2016, 12:52 p.m., Amareshwari Sriramadasu wrote:
> > lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java, line 110
> > <https://reviews.apache.org/r/41794/diff/4/?file=1291407#file1291407line110>
> >
> > Why is this change?
>
> Rajat Khandelwal wrote:
> Hive is storing some temporary output in a directory inside the persist directory. We need to ignore that.
I saw directories like this: file:/Users/rajat.khandelwal/Git/lens/lens-server/target/lens-results/hdfsout/f85154cd-5dcb-436e-90ae-de6fd85bdaf3/.hive-staging_hive_2016-04-27_17-04-02_899_2366544694681523909-4
The directory itself is empty and goes away after some time.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review123989
-----------------------------------------------------------
On April 28, 2016, 12:35 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 28, 2016, 12:35 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 2032cf5a0180139d55a0accf50ef2e8e0809f919
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 02571eecfbe21e9da2dd118eb402374bbe1e3729
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/main/java/org/apache/lens/driver/es/client/jest/JestResultSetTransformer.java 38d91f9cc51b6fa66e8ef5720933bcf6b390668b
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/java/org/apache/lens/driver/es/MockClientES.java 77300f9258816402e28ee92413d1d934c99bfb94
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ResultSetTransformationTest.java 0b786391460b80d809d3c1c092e771a15ca057a6
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 19a010eabc5646e8e0303f73e4ecef91cff8f19f
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java cf5190902f521051a4f8d6f2782944d8990db102
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 765bb45394dab45912ff3ff3b1d6681b39b965ed
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCResultSet.java 9e1a0c060d75cf9ecb4993f28c7736c840b8ff30
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/MockLensResultSetMetadata.java 3b6c0e46e78d0d21d69a83744f0a1de23f9a021b
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensResultSetMetadata.java da90e0ad3a6cb5227fa72761482ac094bf4ba9ef
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java 5295f6826a3c724b3a57e14b529dbf64c4332239
> lens-server-api/src/main/java/org/apache/lens/server/model/MappedDiagnosticLogSegregationContext.java fd5f012059ec5c2b82435fba07d5ca3c23008dae
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 79a628febd1677938705c51475438458d4fafbec
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java f5552dc8c2847c2dda50ed4e98c2ec2774478c45
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 1fa61efb443f25db5c9c650a613b16f046d40155
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java fd6bae3de365cb93710decc9ec9d786406c7b8cc
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 2ee4eb1a596f4caaf8e37ee696388dbd08763434
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml ca5c45d952fd583739c9786a423a6ea538951ab9
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 17, 2016, 12:52 p.m., Amareshwari Sriramadasu wrote:
> > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFileSerdeFormatter.java, line 151
> > <https://reviews.apache.org/r/41794/diff/4/?file=1291408#file1291408line151>
> >
> > Is this a workaround for hive varchar issue? we should revert these in final patch
Yes, this change can be reverted now that HIVE-11484 is merged.
> On March 17, 2016, 12:52 p.m., Amareshwari Sriramadasu wrote:
> > lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java, line 110
> > <https://reviews.apache.org/r/41794/diff/4/?file=1291407#file1291407line110>
> >
> > Why is this change?
Hive is storing some temporary output in a directory inside the persist directory. We need to ignore that.
> On March 17, 2016, 12:52 p.m., Amareshwari Sriramadasu wrote:
> > pom.xml, lines 1663-1688
> > <https://reviews.apache.org/r/41794/diff/4/?file=1291434#file1291434line1663>
> >
> > Why do we have direct dependencies put here? They should be moved to dependency management and required modules should add.
All test dependencies. Required for embedded metastore. Will see if some modules don't need them.
> On March 17, 2016, 12:52 p.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java, line 1247
> > <https://reviews.apache.org/r/41794/diff/4/?file=1291416#file1291416line1247>
> >
> > Why are hitting Hive.get() directly here?
Changed.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review123989
-----------------------------------------------------------
On April 15, 2016, 3:44 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 3:44 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review123989
-----------------------------------------------------------
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java (line 110)
<https://reviews.apache.org/r/41794/#comment186343>
Why is this change?
lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFileSerdeFormatter.java (line 151)
<https://reviews.apache.org/r/41794/#comment186344>
Is this a workaround for hive varchar issue? we should revert these in final patch
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (line 1247)
<https://reviews.apache.org/r/41794/#comment186345>
Why are hitting Hive.get() directly here?
pom.xml (lines 1663 - 1688)
<https://reviews.apache.org/r/41794/#comment186342>
Why do we have direct dependencies put here? They should be moved to dependency management and required modules should add.
- Amareshwari Sriramadasu
On March 8, 2016, 12:15 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 12:15 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd01372e2d8c76d98e83989d952e3dc0779
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b8b6db94ccbad408415f23fa9aba6711c3d4e291
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8d6105f7a0917d9b625b4573807fdafa9fbeea6e
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c68d751358460814b64214675595b812e8f
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java f9d7457facbf5fe42050fdf76448d6344f4eda67
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java cd20fef09468891af5c18aac2a20f71be30afd77
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java f4225439ed50b1bb10d9512423e19749f6383664
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFileSerdeFormatter.java e40d0c2a09490719ff3bc4cd1abb01ebeb3a8742
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a7aecb31d2a497811afeb58b900c5f73df
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a006d6a69b396aad9733593c9a6d383fc24
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 3b091f5ea576eb72ae473e060bbb5b3bef95f106
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 06cae12bbf64495bf1f17eca83fc7877b9441107
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 17, 2016, 10:54 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java, line 1018
> > <https://reviews.apache.org/r/41794/diff/4/?file=1291386#file1291386line1018>
> >
> > Why are these changes in tests?
Some alters are not allowed by hive now. So changed the test case to do the alter that's allowed. Getting this exception with the old code:
org.apache.hadoop.hive.ql.metadata.HiveException: Unable to alter table. The following columns have types incompatible with the existing columns in their respective positions :
msr3
New compatibility check code: https://github.com/apache/hive/blob/master/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java#L876
> On March 17, 2016, 10:54 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java, lines 40-50
> > <https://reviews.apache.org/r/41794/diff/4/?file=1291393#file1291393line40>
> >
> > Can you give details on whats this state about?
This is because we're using embedded mode. In opening a hive session, a new session state is started and previous session state is lost, since it's all happening in the same jvm. For all other session operations (getting status, getting result etc), they are wrapped in `acquire-release` block in `HiveSessionImpl`, and the `release` clears session state for the current thread. Since it's happening in a single thread, the session is cleared for further operations too and needs to be restored for tests to proceed further.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review123982
-----------------------------------------------------------
On March 8, 2016, 5:45 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 5:45 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd01372e2d8c76d98e83989d952e3dc0779
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b8b6db94ccbad408415f23fa9aba6711c3d4e291
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8d6105f7a0917d9b625b4573807fdafa9fbeea6e
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c68d751358460814b64214675595b812e8f
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java f9d7457facbf5fe42050fdf76448d6344f4eda67
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java cd20fef09468891af5c18aac2a20f71be30afd77
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java f4225439ed50b1bb10d9512423e19749f6383664
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFileSerdeFormatter.java e40d0c2a09490719ff3bc4cd1abb01ebeb3a8742
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a7aecb31d2a497811afeb58b900c5f73df
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a006d6a69b396aad9733593c9a6d383fc24
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 3b091f5ea576eb72ae473e060bbb5b3bef95f106
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 06cae12bbf64495bf1f17eca83fc7877b9441107
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 17, 2016, 5:24 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java, lines 40-50
> > <https://reviews.apache.org/r/41794/diff/4/?file=1291393#file1291393line40>
> >
> > Can you give details on whats this state about?
>
> Rajat Khandelwal wrote:
> This is because we're using embedded mode. In opening a hive session, a new session state is started and previous session state is lost, since it's all happening in the same jvm. For all other session operations (getting status, getting result etc), they are wrapped in `acquire-release` block in `HiveSessionImpl`, and the `release` clears session state for the current thread. Since it's happening in a single thread, the session is cleared for further operations too and needs to be restored for tests to proceed further.
Can you add the above as a comment in code itself?
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review123982
-----------------------------------------------------------
On April 19, 2016, 12:49 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated April 19, 2016, 12:49 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cli/pom.xml bfa6f067a68ba470a7064c1d3d3fad44c7169fcf
> lens-client/pom.xml 4fd01fb2cd9fcb156e31bc1fc3b9832566bc2e9a
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 42a8eb24a7b6dead7681909a10f9643b810a4a3f
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java c9b14751013c886be961de585d8113ca543cbe8e
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d0018879deff0f29903e1ffefd93cd497e1edfe
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 18575f68769b1fbd456d82f6a044dda74031e4d1
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b697aa44595865ea56ef24e7b66d006fef
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java b50ebd28b9fb8843efd02345a836d2e178686212
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-es/src/test/resources/logback.xml PRE-CREATION
> lens-driver-hive/pom.xml e80fab80f5fe240e5867a23fc5d17445c6ed6cfc
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java aa37dcc145bc0782e1e329d8e19f19e5840727fb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-ml-lib/pom.xml 0472b70e01bf2a0ef379db3fdefdc4a26954c325
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 94b79d00defe79befd1751a6c552ddaf17bdf59d
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java 0127ef8ae18062955bbd6470e3cda20857e04c24
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6571dae0ee043a20de303a58ab9553b7fd5fe020
> lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java 42bd4abbec230206db854deae8b1e6362576a351
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 45f41c2cb473b213021cc9c1db1f4e2f36c5859a
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java df13ba268ebfdf09def8616ac8329819b413eb5f
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 309921fbad9a3622aac5ad101ec8ede90ae05a31
> src/site/apt/admin/config.apt b5853bfac00d0ba5b4c5409ed6c419050bc86ae5
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/#review123982
-----------------------------------------------------------
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java (line 1018)
<https://reviews.apache.org/r/41794/#comment186328>
Why are these changes in tests?
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java (lines 40 - 50)
<https://reviews.apache.org/r/41794/#comment186329>
Can you give details on whats this state about?
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java (line 645)
<https://reviews.apache.org/r/41794/#comment186330>
Uncomment?
- Amareshwari Sriramadasu
On March 8, 2016, 12:15 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41794/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 12:15 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-518
> https://issues.apache.org/jira/browse/LENS-518
>
>
> Repository: lens
>
>
> Description
> -------
>
> Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
>
>
> Diffs
> -----
>
> lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd01372e2d8c76d98e83989d952e3dc0779
> lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b8b6db94ccbad408415f23fa9aba6711c3d4e291
> lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8d6105f7a0917d9b625b4573807fdafa9fbeea6e
> lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c68d751358460814b64214675595b812e8f
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java f9d7457facbf5fe42050fdf76448d6344f4eda67
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java cd20fef09468891af5c18aac2a20f71be30afd77
> lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
> lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
> lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
> lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java f4225439ed50b1bb10d9512423e19749f6383664
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
> lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
> lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
> lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
> lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
> lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
> lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
> lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
> lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFileSerdeFormatter.java e40d0c2a09490719ff3bc4cd1abb01ebeb3a8742
> lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
> lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
> lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
> lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
> lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
> lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
> lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a7aecb31d2a497811afeb58b900c5f73df
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a006d6a69b396aad9733593c9a6d383fc24
> lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
> lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
> lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
> lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
> lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
> lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 3b091f5ea576eb72ae473e060bbb5b3bef95f106
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
> lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
> lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
> lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
> lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
> pom.xml 06cae12bbf64495bf1f17eca83fc7877b9441107
> tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
>
> Diff: https://reviews.apache.org/r/41794/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 41794: LENS-518: Move Hive dependency to Apache
Hive
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41794/
-----------------------------------------------------------
(Updated March 8, 2016, 5:45 p.m.)
Review request for lens.
Bugs: LENS-518
https://issues.apache.org/jira/browse/LENS-518
Repository: lens
Description
-------
Creating wish for moving to Apache hive dependency instead of forked hive dependency. We will create follow up issues in lens and hive make them link here.
Diffs (updated)
-----
lens-cube/pom.xml 0533f44219d2828792738c8e9fedc7e354820e60
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd01372e2d8c76d98e83989d952e3dc0779
lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java 355a1f0d37d27beec207b4db9b6cce94d0d02268
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java 9318603f2ccb979644c49f863e4e841cd5ad3bd8
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java b8b6db94ccbad408415f23fa9aba6711c3d4e291
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java ebbe404d3a4a6b7e46adc94c0cec35e26cb17acd
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 8d6105f7a0917d9b625b4573807fdafa9fbeea6e
lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 9fecdbccbf188efd39d770662df3606cbf7d766e
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c68d751358460814b64214675595b812e8f
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java f9d7457facbf5fe42050fdf76448d6344f4eda67
lens-cube/src/test/java/org/apache/lens/cube/parse/TestQuery.java cd20fef09468891af5c18aac2a20f71be30afd77
lens-cube/src/test/resources/hive-site.xml 8456f8b6090b953ddbe51604b9e20fbf664cbdc9
lens-driver-es/pom.xml 89736ab8e82f147970dcbc85590a7113bd58597f
lens-driver-es/src/test/java/org/apache/lens/driver/es/ESDriverTest.java ab6f22b34035849275074986466f8015b995cf42
lens-driver-es/src/test/resources/hive-site.xml PRE-CREATION
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/EmbeddedThriftConnection.java 0b46485baf69551eb03ba89cfac980ead0d019eb
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java f4225439ed50b1bb10d9512423e19749f6383664
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveInMemoryResultSet.java 4d52e224a036bea128d2ec0f89d937966d8d1a5c
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveQueryPlan.java f53e2b65580fa01bf5049bcdd511f71cf598f4e7
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java 741294cac27f610b94099c24d59adaa791776487
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java ba3f3d59ec929ecc6b04b4b84e0dd6f68ad06fc0
lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java 4f18c2446e804b4127c1382359d7f38353ec9104
lens-driver-hive/src/test/resources/hive-site.xml de5af502ca8347a962aef34756bfb8a22d67f6f8
lens-driver-jdbc/pom.xml 0dd0fb5dd777021c45d9364e9f1ba1dd5d01fd4f
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java a004de950eaeb6fb4ac5a9663e3ddacac1f7c5ec
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa74914ae524c5f5b7f20fbd0c8df74bb0fc162
lens-driver-jdbc/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
lens-examples/pom.xml a13ee33c7f95a684fd0d2236bc4f39278235ea9b
lens-query-lib/pom.xml 29dbbe10f90689f3c1610619ced9ce41d10bdf8f
lens-query-lib/src/main/java/org/apache/lens/lib/query/FilePersistentFormatter.java b3e640f76ce1007fe5370d461aa3f072fa7876bb
lens-query-lib/src/test/java/org/apache/lens/lib/query/TestFileSerdeFormatter.java e40d0c2a09490719ff3bc4cd1abb01ebeb3a8742
lens-server-api/pom.xml 8304279318c02dc2beb251ec6e87f3f061c86e2b
lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java c7b9887d58c4372faff2419c219da09a16558b15
lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java 0b08459c1107ce3fc79390d092b4a251a1937c75
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 96846c1b89b47a971916ab230bb7f4691d52b524
lens-server/pom.xml 75b8b321d1f6586d4f19abad81e9e86cfe9eb5ea
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java be31cd88d10dc61840c5a2390408ebed126340ac
lens-server/src/main/java/org/apache/lens/server/LensServices.java 48b3e002a75b8ea54c9b8672d50bfc8af25f7483
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a7aecb31d2a497811afeb58b900c5f73df
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a006d6a69b396aad9733593c9a6d383fc24
lens-server/src/main/java/org/apache/lens/server/rewrite/RewriteUtil.java 1c0cd3520ed77f12141042f74d69abbf0fd99790
lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java 72f5c534b02a1fc51ca1fdd98954b113564878e9
lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 2745b272de0d8ce1501c5e3dbde1cb41ec72e8ef
lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 895a819a8469d56eac2e7932ea37a391ee956b17
lens-server/src/main/java/org/apache/lens/server/stats/store/log/StatisticsLogPartitionHandler.java 6d92ab9c1f66d0088ffca58f6ae36e6547c37be6
lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java 0f55d9e49312a1668dbff3712032359bb92545fc
lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 0e39b52ce86b9c036d48c8fd395b96fa86bbcd9e
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java 3b091f5ea576eb72ae473e060bbb5b3bef95f106
lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 699fa686f5feb865b029b4024e049520a22840da
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java f66f89d933e0c380acd56af921e37da58f97c83d
lens-server/src/test/java/org/apache/lens/server/rewrite/TestRewriting.java 0e640ec66ba45716f4819cfd3d944a6155305078
lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java 5feab715b9a283e0951570a407b464b3bd7007a6
lens-server/src/test/java/org/apache/lens/server/session/TestSessionExpiry.java dbdaaecb58e2c8dcad7b8ce0157f9f74cbb38484
lens-server/src/test/resources/hive-site.xml 441f2741c7c55bace15b6c723caaf8eb76724666
lens-storage-db/pom.xml ed583413d51258fea6c555c759905f82be77b7d9
lens-storage-db/src/test/resources/hive-site.xml 2cb1d8d47fc7161ea2667c34eb0c1bf0bd10945e
pom.xml 06cae12bbf64495bf1f17eca83fc7877b9441107
tools/conf/server/lens-site.xml 0803da168c10f93ca915e47356151154148ae0c2
Diff: https://reviews.apache.org/r/41794/diff/
Testing
-------
Thanks,
Rajat Khandelwal