You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/20 10:15:46 UTC
[GitHub] [flink] zentol commented on a change in pull request #11140:
[FLINK-16172][build] Add baseline set of allowed unused dependencies
zentol commented on a change in pull request #11140: [FLINK-16172][build] Add baseline set of allowed unused dependencies
URL: https://github.com/apache/flink/pull/11140#discussion_r381904774
##########
File path: pom.xml
##########
@@ -1676,6 +1676,44 @@ under the License.
<version>1.11.1</version>
</dependency>
</dependencies>
+ <configuration>
+ <ignoredUsedUndeclaredDependencies combine.children="append">
+ <!-- allow using transitive Flink dependencies for brevity -->
+ <dependency>org.apache.flink:*</dependency>
Review comment:
not sure, but I would advice against it anyway since unused test dependencies are also problematic form a maintenance perspective as the still restrict the dependency graph (in case of Flink dependencies) and may introduce dependency conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services