You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/06/13 22:07:43 UTC

[GitHub] [kafka] ableegoldman opened a new pull request, #12288: HOTFIX: null check for ProducerRecord when computing sizeInBytes

ableegoldman opened a new pull request, #12288:
URL: https://github.com/apache/kafka/pull/12288

   Minor followup to #12235  that adds a null check on the record key in the new ClientUtils#producerRecordSizeInBytes utility method, as there are valid cases in which we might be sending records with null keys to the Producer, such as a simple `builder.stream("non-keyed-input-topic").filter(...).to("output-topic")`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] ableegoldman merged pull request #12288: HOTFIX: null check for ProducerRecord when computing sizeInBytes

Posted by GitBox <gi...@apache.org>.
ableegoldman merged PR #12288:
URL: https://github.com/apache/kafka/pull/12288


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] ableegoldman commented on pull request #12288: HOTFIX: null check for ProducerRecord when computing sizeInBytes

Posted by GitBox <gi...@apache.org>.
ableegoldman commented on PR #12288:
URL: https://github.com/apache/kafka/pull/12288#issuecomment-1154724371

   Failing tests are unrelated:
   `testIncrementalAlterConfigs() – kafka.server.KRaftClusterTest`
   `testFailureToFenceEpoch(String).quorum=kraft – kafka.api.TransactionsTest`
   
   Merging this fix


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org