You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Ashish Singh <as...@cloudera.com> on 2015/07/02 02:46:44 UTC
Re: Review Request 35850: Patch for KAFKA-2301
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35850/
-----------------------------------------------------------
(Updated July 2, 2015, 12:46 a.m.)
Review request for kafka.
Bugs: KAFKA-2301
https://issues.apache.org/jira/browse/KAFKA-2301
Repository: kafka
Description
-------
KAFKA-2301: Deprecate ConsumerOffsetChecker
Diffs (updated)
-----
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 3d52f62c88a509a655cf1df6232b738c25fa9b69
Diff: https://reviews.apache.org/r/35850/diff/
Testing
-------
Thanks,
Ashish Singh
Re: Review Request 35850: Patch for KAFKA-2301
Posted by Ashish Singh <as...@cloudera.com>.
> On July 2, 2015, 8:01 a.m., Ewen Cheslack-Postava wrote:
> > core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala, line 110
> > <https://reviews.apache.org/r/35850/diff/2/?file=997797#file997797line110>
> >
> > Since this is a warning, can we just use warn() instead of info()? Otherwise, this trivial patch LGTM!
The reason I had it as info was if someone is suppressing warnings they might not get this message. However, I guess that is the price they pay for suppressing warnings. Made the change.
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35850/#review90199
-----------------------------------------------------------
On July 2, 2015, 4:04 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35850/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 4:04 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2301
> https://issues.apache.org/jira/browse/KAFKA-2301
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-2301: Deprecate ConsumerOffsetChecker
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 3d52f62c88a509a655cf1df6232b738c25fa9b69
>
> Diff: https://reviews.apache.org/r/35850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 35850: Patch for KAFKA-2301
Posted by Ewen Cheslack-Postava <me...@ewencp.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35850/#review90199
-----------------------------------------------------------
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala (line 110)
<https://reviews.apache.org/r/35850/#comment143205>
Since this is a warning, can we just use warn() instead of info()? Otherwise, this trivial patch LGTM!
- Ewen Cheslack-Postava
On July 2, 2015, 12:46 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35850/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 12:46 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2301
> https://issues.apache.org/jira/browse/KAFKA-2301
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-2301: Deprecate ConsumerOffsetChecker
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 3d52f62c88a509a655cf1df6232b738c25fa9b69
>
> Diff: https://reviews.apache.org/r/35850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 35850: Patch for KAFKA-2301
Posted by Guozhang Wang <wa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35850/#review93346
-----------------------------------------------------------
Ship it!
Ship It!
- Guozhang Wang
On July 2, 2015, 4:04 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35850/
> -----------------------------------------------------------
>
> (Updated July 2, 2015, 4:04 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-2301
> https://issues.apache.org/jira/browse/KAFKA-2301
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-2301: Deprecate ConsumerOffsetChecker
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 3d52f62c88a509a655cf1df6232b738c25fa9b69
>
> Diff: https://reviews.apache.org/r/35850/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 35850: Patch for KAFKA-2301
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35850/
-----------------------------------------------------------
(Updated July 2, 2015, 4:04 p.m.)
Review request for kafka.
Bugs: KAFKA-2301
https://issues.apache.org/jira/browse/KAFKA-2301
Repository: kafka
Description
-------
KAFKA-2301: Deprecate ConsumerOffsetChecker
Diffs (updated)
-----
core/src/main/scala/kafka/tools/ConsumerOffsetChecker.scala 3d52f62c88a509a655cf1df6232b738c25fa9b69
Diff: https://reviews.apache.org/r/35850/diff/
Testing
-------
Thanks,
Ashish Singh