[jira] [Resolved] (IMPALA-4737) If minidumps are disabled, SIGUSR1 goes unhandled and will crash the process

["Lars Volker (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-4737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Volker resolved IMPALA-4737.
---------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 2.10.0

IMPALA-4737: Prevent SIGUSR1 from killing daemons when minidumps are disabled

If a user disabled minidumps before this change, we did not register the
signal handler for SIGUSR1 at all. Sending SIGUSR1 to a daemon would
subsequently kill it.

This change registers the SIG_IGN handler to ignore the signal if
minidumps are disabled.

Change-Id: I13d866a2eec832500131954a7f693c33585ea51e
Reviewed-on: http://gerrit.cloudera.org:8080/7631
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins

> If minidumps are disabled, SIGUSR1 goes unhandled and will crash the process
> ----------------------------------------------------------------------------
>
>                 Key: IMPALA-4737
>                 URL: https://issues.apache.org/jira/browse/IMPALA-4737
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 2.7.0
>            Reporter: Lars Volker
>            Assignee: Lars Volker
>            Priority: Critical
>              Labels: breakpad
>             Fix For: Impala 2.10.0
>
>
> When disabling minidumps by setting 'minidump_path' to an empty string, the signal handler for {{SIGUSR1}} in {{be/src/util/minidump.cc}} is not registered, leaving the signal unhandled. If someone sends that signal to the process, it will crash.
> We should register a signal handler nonetheless and either ignore the signal or print a log message explaining that minidumps are disabled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)