You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2015/12/16 17:50:06 UTC

[Bug 58743] New: TableEditor could have its content not well saved (or loaded)

https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

            Bug ID: 58743
           Summary: TableEditor could have its content not well saved (or
                    loaded)
           Product: JMeter
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: vherilier@gmail.com

Hi,

Using 2 elements of the same kind with a TableEditor inside (AssertionCompare),
one with its table filled, the other one with an empty table, if I save the
test from the element with the empty content every works fine, but if I save
from the other element 2 errors are raised (see save.log file attached)

NB: This issue is more visible if issue 58742 is fixed.

Adding a third element of the same kind after the two others with its table
filled and saving the test well, if the test is reloaded, 4 errors are raised
(see load.log filee attached) and the empty table of the second element is
filled by the same content than the third one.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

Vincent HERILIER <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |58742

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

--- Comment #10 from Emilian Bold <em...@apache.org> ---
I've fixed this bug. See patch in this pull request:
https://github.com/apache/jmeter/pull/293

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743
Bug 58743 depends on bug 58742, which changed state.

Bug 58742 Summary: TableEditor duplicates content from an element with filled table to an element with an empty one
https://bz.apache.org/bugzilla/show_bug.cgi?id=58742

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

--- Comment #2 from Vincent HERILIER <vh...@gmail.com> ---
Created attachment 33355
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33355&action=edit
log when the test is loaded

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

Vincent HERILIER <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |critical

--- Comment #7 from Vincent HERILIER <vh...@gmail.com> ---
The issue, just have been experienced once again by the JMeter users I'm
working with.
They lost their files because the issue truncates the XML content.
It is a critical data integrity issue.

After some investigations in JMeter code, I have difficulties to found where is
really the root cause.
Maybe you have an idea of what could produce such issue.
And from your suggestion, I hope finding the issue and submit you a fix

thanks again for your support and suggestion

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

--- Comment #5 from Vincent HERILIER <vh...@gmail.com> ---
Created attachment 33362
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33362&action=edit
Test case showing issue as a file is loaded

The test case is composed from a Thread Group with 2 Compare Assertion
elements:
The first one has an empty TableEditor widget, the second has a row inserted
into its TableEditor widget.
Loading the file generates 2 errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

Felix Schumacher <fe...@internetallee.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #12 from Felix Schumacher <fe...@internetallee.de> ---
Thanks Emilian for the fix.

This will be included in version 3.3.

Date: Fri Apr 28 19:30:23 2017
New Revision: 1793138

URL: http://svn.apache.org/viewvc?rev=1793138&view=rev
Log:
TableEditor can't be saved, when using two or more instances.

Bugfix provided by Emilian Bold (emi at apache.org)
This closes #293 on github.

Bugzilla Id: 58743

Added:
   
jmeter/trunk/test/src/org/apache/jmeter/testelement/property/AbstractPropertyTest.java
  (with props)
Modified:
   
jmeter/trunk/src/core/org/apache/jmeter/testelement/property/AbstractProperty.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

--- Comment #4 from Vincent HERILIER <vh...@gmail.com> ---
Created attachment 33361
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33361&action=edit
Test case showing the issue that truncates jmx files

The test case is composed from a Thread Group with 2 Compare Assertion
elements:
The first one has a row inserted in its TableEditor widget, the second has an
empty one.
NB: switching from the to the other produce the bug 58742 so insure to delete
intenpestive content added.
So if you are focused on the empty assertion element and that you perform a
Save Action, everything goes.
Switch to the "filled" assertion element and Save the file, 2 errors are
raised.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

Vincent HERILIER <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |60124


Referenced Bugs:

https://bz.apache.org/bugzilla/show_bug.cgi?id=60124
[Bug 60124] Strange ClassCastException when try to save test plan with TestBean
GUI and collection properties (TableEditor)
-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

Vincent HERILIER <vh...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #6 from Vincent HERILIER <vh...@gmail.com> ---
Hi Philippe,

I hope the 2 test cases will help you in your investigations.
Feel free to ask more information if required.

Thank you

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

--- Comment #11 from Felix Schumacher <fe...@internetallee.de> ---
Created attachment 34956
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34956&action=edit
Testcase for AbstractProperty#normalizeList

The attached patch is for the proposed changes of pr #293.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|critical                    |major

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |2.6
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

--- Comment #1 from Vincent HERILIER <vh...@gmail.com> ---
Created attachment 33354
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=33354&action=edit
log when the test is saved

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
             Status|NEW                         |NEEDINFO

--- Comment #3 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Hello,
Could you provide a Test plan and some screenshot ?
Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |Alexander_Sergey@mail.ru

--- Comment #9 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
*** Bug 60124 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 58743] TableEditor could have its content not well saved (or loaded)

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58743

--- Comment #8 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
Scenario related to Bug 60124:
- Create a Compare Assertion and fill in a row with 2 fields
- Create another Compare Assertion and keep it empty

Select last Compare Assertion and save => OK
Select first Compare Assertion and save => KO

-- 
You are receiving this mail because:
You are the assignee for the bug.