You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "John Sherman (Jira)" <ji...@apache.org> on 2021/04/13 21:32:00 UTC
[jira] [Comment Edited] (IMPALA-10657) Remove usage of shaded
imports
[ https://issues.apache.org/jira/browse/IMPALA-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320545#comment-17320545 ]
John Sherman edited comment on IMPALA-10657 at 4/13/21, 9:31 PM:
-----------------------------------------------------------------
Sure
{code:java}
fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java uses org.apache.kudu.shaded.com.google.common.collect.Lists
fe/src/main/java/org/apache/impala/catalog/Transaction.java uses org.apache.curator.shaded.com.google.common.base.Preconditions
fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java uses org.apache.curator.shaded.com.google.common.collect.Iterables
fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java uses org.apache.curator.shaded.com.google.common.collect.Sets
{code}
was (Author: jfs):
Sure
fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java - uses org.apache.kudu.shaded.com.google.common.collect.Lists
fe/src/main/java/org/apache/impala/catalog/Transaction.java - uses org.apache.curator.shaded.com.google.common.base.Preconditions
fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java - org.apache.curator.shaded.com.google.common.collect.Iterables
fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java - uses org.apache.curator.shaded.com.google.common.collect.Sets
> Remove usage of shaded imports
> ------------------------------
>
> Key: IMPALA-10657
> URL: https://issues.apache.org/jira/browse/IMPALA-10657
> Project: IMPALA
> Issue Type: Improvement
> Components: Frontend
> Reporter: John Sherman
> Assignee: John Sherman
> Priority: Major
>
> It seems there are a few spots where maybe an IDE automatically resolved a FE or test import to from a shaded dependency. We should use the direct dependency to remove confusion and reduce the required jars for some usages of the FE code.
> Examples being:
> fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java uses org.apache.kudu.shaded.com.google.common.collect.Lists
> fe/src/main/java/org/apache/impala/catalog/Transaction.java uses org.apache.curator.shaded.com.google.common.base.Preconditions
> fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java use org.apache.curator.shaded.com.google.common.collect.Iterables
> fe/src/test/java/org/apache/impala/analysis/ExprCardinalityTest.java uses org.apache.curator.shaded.com.google.common.collect.Sets
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org