You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by "igodwin (GitHub)" <gi...@apache.org> on 2019/01/26 02:47:25 UTC

[GitHub] [geode-native] igodwin opened pull request #439: GEODE-6054: Move Windows CI workers to Server 2016 and VS 2017

Windows CI workers have been updated to the latest Windows Server 2016 release, and now use Visual Studio 2017 for builds. A lot of work done to get the latest version of openssh (from Chocolatey) to work on Server 2016, as well as migrate EC2 initialization and cleanup scripts to work with current methods.

[ Full content available at: https://github.com/apache/geode-native/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] codecov-io commented on issue #439: GEODE-6054: Move Windows CI workers to Server 2016 and VS 2017

Posted by "codecov-io (GitHub)" <gi...@apache.org>.

# [Codecov](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=h1) Report
> Merging [#439](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/7dae2c1c3162281508a70f5c60182b5390d81288?src=pr&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/439/graphs/tree.svg?width=650&token=plpAqoqGag&height=150&src=pr)](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #439      +/-   ##
===========================================
+ Coverage    72.23%   72.26%   +0.03%     
===========================================
  Files          654      654              
  Lines        52351    52351              
===========================================
+ Hits         37814    37830      +16     
+ Misses       14537    14521      -16
```


| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `55.7% <0%> (-0.46%)` | :arrow_down: |
| [cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw) | `67.63% <0%> (+0.06%)` | :arrow_up: |
| [cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==) | `73.98% <0%> (+0.4%)` | :arrow_up: |
| [cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=) | `59.18% <0%> (+0.45%)` | :arrow_up: |
| [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `72.5% <0%> (+0.46%)` | :arrow_up: |
| [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `53.19% <0%> (+0.83%)` | :arrow_up: |
| [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `63.31% <0%> (+1.13%)` | :arrow_up: |
| [cppcache/src/TcrPoolEndPoint.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjclBvb2xFbmRQb2ludC5jcHA=) | `86.48% <0%> (+5.4%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=footer). Last update [7dae2c1...35e0d72](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/geode-native/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] pdxcodemonkey closed pull request #439: GEODE-6054: Move Windows CI workers to Server 2016 and VS 2017

Posted by "pdxcodemonkey (GitHub)" <gi...@apache.org>.

[ pull request closed by pdxcodemonkey ]

[ Full content available at: https://github.com/apache/geode-native/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] codecov-io commented on issue #439: GEODE-6054: Move Windows CI workers to Server 2016 and VS 2017

Posted by "codecov-io (GitHub)" <gi...@apache.org>.

# [Codecov](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=h1) Report
> Merging [#439](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/7dae2c1c3162281508a70f5c60182b5390d81288?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/439/graphs/tree.svg?width=650&token=plpAqoqGag&height=150&src=pr)](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #439      +/-   ##
===========================================
- Coverage    72.23%   72.18%   -0.05%     
===========================================
  Files          654      654              
  Lines        52351    52351              
===========================================
- Hits         37814    37792      -22     
- Misses       14537    14559      +22
```


| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cppcache/src/ReadWriteLock.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlYWRXcml0ZUxvY2suY3Bw) | `81.25% <0%> (-18.75%)` | :arrow_down: |
| [cppcache/src/statistics/StatArchiveWriter.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL3N0YXRpc3RpY3MvU3RhdEFyY2hpdmVXcml0ZXIuY3Bw) | `81.63% <0%> (-1.46%)` | :arrow_down: |
| [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `51.38% <0%> (-0.98%)` | :arrow_down: |
| [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `55.3% <0%> (-0.86%)` | :arrow_down: |
| [cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw) | `67.35% <0%> (-0.21%)` | :arrow_down: |
| [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `72.34% <0%> (+0.31%)` | :arrow_up: |
| [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `63.17% <0%> (+0.99%)` | :arrow_up: |
| [cppcache/src/TcrPoolEndPoint.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjclBvb2xFbmRQb2ludC5jcHA=) | `86.48% <0%> (+5.4%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=footer). Last update [7dae2c1...35e0d72](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/geode-native/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] codecov-io commented on issue #439: GEODE-6054: Move Windows CI workers to Server 2016 and VS 2017

Posted by "codecov-io (GitHub)" <gi...@apache.org>.

# [Codecov](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=h1) Report
> Merging [#439](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/7dae2c1c3162281508a70f5c60182b5390d81288?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `n/a`.

[![Impacted file tree graph](https://codecov.io/gh/apache/geode-native/pull/439/graphs/tree.svg?width=650&token=plpAqoqGag&height=150&src=pr)](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #439      +/-   ##
===========================================
+ Coverage    72.23%   72.26%   +0.02%     
===========================================
  Files          654      654              
  Lines        52351    52351              
===========================================
+ Hits         37814    37829      +15     
+ Misses       14537    14522      -15
```


| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [cppcache/src/ThinClientRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWdpb24uY3Bw) | `55.7% <0%> (-0.46%)` | :arrow_down: |
| [cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==) | `73.98% <0%> (+0.4%)` | :arrow_up: |
| [cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=) | `59.18% <0%> (+0.45%)` | :arrow_up: |
| [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `72.5% <0%> (+0.46%)` | :arrow_up: |
| [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `53.19% <0%> (+0.83%)` | :arrow_up: |
| [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `63.31% <0%> (+1.13%)` | :arrow_up: |
| [cppcache/src/TcrPoolEndPoint.cpp](https://codecov.io/gh/apache/geode-native/pull/439/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjclBvb2xFbmRQb2ludC5jcHA=) | `86.48% <0%> (+5.4%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=footer). Last update [7dae2c1...35e0d72](https://codecov.io/gh/apache/geode-native/pull/439?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/geode-native/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode-native] moleske commented on issue #439: GEODE-6054: Move Windows CI workers to Server 2016 and VS 2017

Posted by "moleske (GitHub)" <gi...@apache.org>.

I don't see any readme/building dot md changes, is that something that needs updating also?

[ Full content available at: https://github.com/apache/geode-native/pull/439 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org