[jira] [Comment Edited] (MESOS-7365) Compile error with recent glibc

["Yan Xu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-7365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993931#comment-15993931 ] 

Yan Xu edited comment on MESOS-7365 at 5/2/17 10:48 PM:
--------------------------------------------------------

Looks like this breaks on glibc versions < 2.13.90-12 (see MESOS-7378), should we do this conditionally? Otherwise we have to drop support for glibc < 2.13.90-12 for this (despite that nothing else breaks on it).

[~neilc] [~anandmazumdar]


was (Author: xujyan):
Looks like this breaks on glibc versions < 2.13.90-12 (see MESOS-7378), should we do this conditionally? Otherwise we have to drop support for glibc < 2.13.90-12 for this (despite that nothing else breaks on it).

> Compile error with recent glibc
> -------------------------------
>
>                 Key: MESOS-7365
>                 URL: https://issues.apache.org/jira/browse/MESOS-7365
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Neil Conway
>            Assignee: Neil Conway
>              Labels: mesosphere
>             Fix For: 1.3.0
>
>
> {noformat}
> ../../mesos/src/slave/containerizer/mesos/isolators/gpu/isolator.cpp:152:13: error: In the GNU C Library, "major" is defined
>  by <sys/sysmacros.h>. For historical compatibility, it is
>  currently defined by <sys/types.h> as well, but we plan to
>  remove this soon. To use "major", include <sys/sysmacros.h>
>  directly. If you did not intend to use a system-defined macro
>  "major", you should undefine it after including <sys/types.h>. [-Werror]
>    entry.selector.major = major(device.get());
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> {noformat}
> Observed on recent Arch Linux, GCC 6.3.1, glibc 2.25-1.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)