You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Brenden Matthews <br...@diddyinc.com> on 2013/07/30 21:26:27 UTC
Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos-git
Description
-------
Updated Mesos mapred-site.xml for Hadoop.
Diffs
-----
hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3
Diff: https://reviews.apache.org/r/13077/diff/
Testing
-------
Used in production at Airbnb.
make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
Thanks,
Brenden Matthews
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 1:47 a.m.)
Review request for mesos.
Changes
-------
Rebasing on master.
Repository: mesos-git
Description
-------
Updated Mesos mapred-site.xml for Hadoop.
Review: https://reviews.apache.org/r/13077
Diffs (updated)
-----
hadoop/mapred-site.xml.patch d5a99f6f649e468f18255323f4f7fb5d8613bca8
Diff: https://reviews.apache.org/r/13077/diff/
Testing
-------
Used in production at Airbnb.
make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
Thanks,
Brenden Matthews
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/
-----------------------------------------------------------
(Updated July 30, 2013, 11:46 p.m.)
Review request for mesos.
Changes
-------
Updated to reflect 2 new knobs.
Repository: mesos-git
Description
-------
Updated Mesos mapred-site.xml for Hadoop.
Review: https://reviews.apache.org/r/13077
Diffs (updated)
-----
hadoop/mapred-site.xml.patch d5a99f6f649e468f18255323f4f7fb5d8613bca8
Diff: https://reviews.apache.org/r/13077/diff/
Testing
-------
Used in production at Airbnb.
make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
Thanks,
Brenden Matthews
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/#review24291
-----------------------------------------------------------
Ship it!
ty
- Vinod Kone
On July 30, 2013, 9:19 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13077/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 9:19 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated Mesos mapred-site.xml for Hadoop.
>
> Review: https://reviews.apache.org/r/13077
>
>
> Diffs
> -----
>
> hadoop/mapred-site.xml.patch d5a99f6f649e468f18255323f4f7fb5d8613bca8
>
> Diff: https://reviews.apache.org/r/13077/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/
-----------------------------------------------------------
(Updated July 30, 2013, 9:19 p.m.)
Review request for mesos.
Changes
-------
Updated as per Ben and Vinod's comments.
Repository: mesos-git
Description
-------
Updated Mesos mapred-site.xml for Hadoop.
Review: https://reviews.apache.org/r/13077
Diffs (updated)
-----
hadoop/mapred-site.xml.patch d5a99f6f649e468f18255323f4f7fb5d8613bca8
Diff: https://reviews.apache.org/r/13077/diff/
Testing
-------
Used in production at Airbnb.
make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
Thanks,
Brenden Matthews
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Brenden Matthews <br...@diddyinc.com>.
> On July 30, 2013, 8:56 p.m., Ben Mahler wrote:
> > hadoop/mapred-site.xml.patch, line 50
> > <https://reviews.apache.org/r/13077/diff/2/?file=330784#file330784line50>
> >
> > Wrap this one?
Weird. I think something got messed up in the git shuffle required to please review board.
- Brenden
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/#review24283
-----------------------------------------------------------
On July 30, 2013, 7:44 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13077/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 7:44 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated Mesos mapred-site.xml for Hadoop.
>
> Review: https://reviews.apache.org/r/13077
>
>
> Diffs
> -----
>
> hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3
>
> Diff: https://reviews.apache.org/r/13077/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/#review24283
-----------------------------------------------------------
Ship it!
hadoop/mapred-site.xml.patch
<https://reviews.apache.org/r/13077/#comment48117>
Wrap this one?
hadoop/mapred-site.xml.patch
<https://reviews.apache.org/r/13077/#comment48116>
Kill newline or re-format the tags?
- Ben Mahler
On July 30, 2013, 7:44 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13077/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 7:44 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated Mesos mapred-site.xml for Hadoop.
>
> Review: https://reviews.apache.org/r/13077
>
>
> Diffs
> -----
>
> hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3
>
> Diff: https://reviews.apache.org/r/13077/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/#review24284
-----------------------------------------------------------
hadoop/mapred-site.xml.patch
<https://reviews.apache.org/r/13077/#comment48118>
While you are fixing the documentation, would you mind also fixing this. I've seen some confusion about using the executor bundle.
Rephrase NOTE:
You need to MANUALLY upload the Mesos Hadoop distribution to the location that is set as the value of this property. This distribution is built for you, after you run 'make hadoop-*', at 'hadoop/build/hadoop.tar.gz'. This distribution contains all the required Mesos patches.
s/hadoop.zip/hadoop.tar.gz/
- Vinod Kone
On July 30, 2013, 7:44 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13077/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 7:44 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated Mesos mapred-site.xml for Hadoop.
>
> Review: https://reviews.apache.org/r/13077
>
>
> Diffs
> -----
>
> hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3
>
> Diff: https://reviews.apache.org/r/13077/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/
-----------------------------------------------------------
(Updated July 30, 2013, 7:44 p.m.)
Review request for mesos.
Changes
-------
Add dependency.
Repository: mesos-git
Description
-------
Updated Mesos mapred-site.xml for Hadoop.
Review: https://reviews.apache.org/r/13077
Diffs
-----
hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3
Diff: https://reviews.apache.org/r/13077/diff/
Testing
-------
Used in production at Airbnb.
make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
Thanks,
Brenden Matthews
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Brenden Matthews <br...@diddyinc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/
-----------------------------------------------------------
(Updated July 30, 2013, 7:44 p.m.)
Review request for mesos.
Changes
-------
Updated as per Ben's comments.
Repository: mesos-git
Description (updated)
-------
Updated Mesos mapred-site.xml for Hadoop.
Review: https://reviews.apache.org/r/13077
Diffs (updated)
-----
hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3
Diff: https://reviews.apache.org/r/13077/diff/
Testing
-------
Used in production at Airbnb.
make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
Thanks,
Brenden Matthews
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/#review24270
-----------------------------------------------------------
Ship it!
Awesome documentation!
hadoop/mapred-site.xml.patch
<https://reviews.apache.org/r/13077/#comment48094>
s/. /. / on all of these?
hadoop/mapred-site.xml.patch
<https://reviews.apache.org/r/13077/#comment48095>
Can you end with a period?
hadoop/mapred-site.xml.patch
<https://reviews.apache.org/r/13077/#comment48096>
Looks like this one and the ones below are wrapped with newlines, whereas the ones above are not?
hadoop/mapred-site.xml.patch
<https://reviews.apache.org/r/13077/#comment48097>
Close </property> tag on next line.
hadoop/mapred-site.xml.patch
<https://reviews.apache.org/r/13077/#comment48098>
For multi-line tags, perhaps we should format like this:
<description>
This is my description!
</description>
- Ben Mahler
On July 30, 2013, 7:26 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13077/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 7:26 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated Mesos mapred-site.xml for Hadoop.
>
>
> Diffs
> -----
>
> hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3
>
> Diff: https://reviews.apache.org/r/13077/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
>
>
> Thanks,
>
> Brenden Matthews
>
>
Re: Review Request 13077: Updated Mesos mapred-site.xml for Hadoop.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13077/#review24269
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 30, 2013, 7:26 p.m., Brenden Matthews wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13077/
> -----------------------------------------------------------
>
> (Updated July 30, 2013, 7:26 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Updated Mesos mapred-site.xml for Hadoop.
>
>
> Diffs
> -----
>
> hadoop/mapred-site.xml.patch 8b3997944f60a9d91c81089a4450e4820526dde3
>
> Diff: https://reviews.apache.org/r/13077/diff/
>
>
> Testing
> -------
>
> Used in production at Airbnb.
>
> make check && cd hadoop && make hadoop-2.0.0-mr1-cdh4.2.1
>
>
> Thanks,
>
> Brenden Matthews
>
>