You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/08/05 11:31:23 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #25355: [SPARK-28615][SQL][DOCS] Add a guide line for dataframe functions to say column signature function is by default

cloud-fan commented on a change in pull request #25355: [SPARK-28615][SQL][DOCS] Add a guide line for dataframe functions to say column signature function is by default
URL: https://github.com/apache/spark/pull/25355#discussion_r310559578
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/functions.scala
 ##########
 @@ -55,6 +55,9 @@ import org.apache.spark.util.Utils
  * `regr_count` is an example of a function that is built-in but not defined here, because it is
  * less commonly used. To invoke it, use `expr("regr_count(yCol, xCol)")`.
  *
+ * We add these functions with `Column` type arguments by default. All the other variants are there
 
 Review comment:
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org