You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2004/10/23 19:58:32 UTC

cvs commit: jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui ProxyControlGui.java

sebb        2004/10/23 10:58:32

  Modified:    src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui
                        Tag: rel-2_0 ProxyControlGui.java
  Log:
  Comment out unused code
  
  Revision  Changes    Path
  No                   revision
  No                   revision
  1.41.2.1  +12 -3     jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java
  
  Index: ProxyControlGui.java
  ===================================================================
  RCS file: /home/cvs/jakarta-jmeter/src/protocol/http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java,v
  retrieving revision 1.41
  retrieving revision 1.41.2.1
  diff -u -r1.41 -r1.41.2.1
  --- ProxyControlGui.java	5 Mar 2004 01:38:42 -0000	1.41
  +++ ProxyControlGui.java	23 Oct 2004 17:58:32 -0000	1.41.2.1
  @@ -688,6 +688,10 @@
                   StringBuffer name = new StringBuffer();
                   JMeterTreeNode cur = (JMeterTreeNode) node.getChildAt(i);
                   TestElement te = cur.getTestElement();
  +/*
  + * Will never be true. 
  + * Probably intended to use org.apache.jmeter.threads.ThreadGroup rather than java.lang.ThreadGroup
  + * However, that does not work correctly; whereas treating it as a Controller does.
                   if (te instanceof ThreadGroup)
                   {
                       name.append(parent_name);
  @@ -695,7 +699,9 @@
                       name.append(seperator);
                       buildNodesModel(cur, name.toString(), level);
                   }
  -                else if (te instanceof Controller)
  +                else
  +*/ 
  +               	if (te instanceof Controller)
                   {
                       name.append(spaces(level));
                       name.append(parent_name);
  @@ -713,6 +719,9 @@
                       name.append(cur.getName());
                       name.append(seperator);
                       buildNodesModel(cur, name.toString(), 0);
  +                }
  +                else {
  +                	log.error("Cannot process "+te);
                   }
               }
           }
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org