You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/19 10:46:35 UTC
[GitHub] [druid] JaeGeunBang opened a new pull request #9538: Delete
unnecessary links
JaeGeunBang opened a new pull request #9538: Delete unnecessary links
URL: https://github.com/apache/druid/pull/9538
### Description
Delete unnecessary links ([.idea/...](.idea/runConfigurations)) and change backtick (`./idea/...`) because the format of ./idea/... in the teamcity.md file is backtick.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9538:
Delete unnecessary links
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9538: Delete unnecessary links
URL: https://github.com/apache/druid/pull/9538#discussion_r395406869
##########
File path: dev/intellij-setup.md
##########
@@ -24,7 +24,7 @@ setups of Druid.
## Project SDK
The "SDK", configured for the Druid project, *must* be called `1.8`, to avoid annoying changes of
-[.idea/misc.xml](`.idea/misc.xml`) file, that you shouldn't check into your commits. If you don't have an SDK on your
+`.idea/misc.xml` file, that you shouldn't check into your commits. If you don't have an SDK on your
Review comment:
These still seem potentially useful to have as links, but they are currently broken, so how about changing to
```
[`.idea/misc.xml`](/.idea/misc.xml)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9538:
Delete unnecessary links
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9538: Delete unnecessary links
URL: https://github.com/apache/druid/pull/9538#discussion_r395407024
##########
File path: dev/intellij-setup.md
##########
@@ -46,7 +46,7 @@ This also assumes you have [ZooKeeper](http://zookeeper.apache.org/releases.html
Before running the apps, you should do a `mvn clean install -DskipTests` in the Druid source in order to make sure directories are populated correctly.
## XML App Def
-You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in [.idea/runConfigurations](.idea/runConfigurations) in the Druid source code.
+You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in `.idea/runConfigurations` in the Druid source code.
Review comment:
Same suggestion about retaining links
```
[`.idea/runConfigurations`](/.idea/runConfigurations)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] JaeGeunBang closed pull request #9538: Delete unnecessary
links
Posted by GitBox <gi...@apache.org>.
JaeGeunBang closed pull request #9538: Delete unnecessary links
URL: https://github.com/apache/druid/pull/9538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis commented on a change in pull request #9538:
Delete unnecessary links
Posted by GitBox <gi...@apache.org>.
clintropolis commented on a change in pull request #9538: Delete unnecessary links
URL: https://github.com/apache/druid/pull/9538#discussion_r395493873
##########
File path: dev/intellij-setup.md
##########
@@ -46,7 +46,7 @@ This also assumes you have [ZooKeeper](http://zookeeper.apache.org/releases.html
Before running the apps, you should do a `mvn clean install -DskipTests` in the Druid source in order to make sure directories are populated correctly.
## XML App Def
-You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in [.idea/runConfigurations](.idea/runConfigurations) in the Druid source code.
+You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in `.idea/runConfigurations` in the Druid source code.
Review comment:
sounds good :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] JaeGeunBang commented on a change in pull request #9538:
Delete unnecessary links
Posted by GitBox <gi...@apache.org>.
JaeGeunBang commented on a change in pull request #9538: Delete unnecessary links
URL: https://github.com/apache/druid/pull/9538#discussion_r395417319
##########
File path: dev/intellij-setup.md
##########
@@ -46,7 +46,7 @@ This also assumes you have [ZooKeeper](http://zookeeper.apache.org/releases.html
Before running the apps, you should do a `mvn clean install -DskipTests` in the Druid source in order to make sure directories are populated correctly.
## XML App Def
-You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in [.idea/runConfigurations](.idea/runConfigurations) in the Druid source code.
+You can configure application definitions in XML for import into IntelliJ. Below are a few examples. These should be placed in an XML file in `.idea/runConfigurations` in the Druid source code.
Review comment:
@clintropolis
Thank you!
If the suggestion above, how about changing the ./idea/ in `teamcity.md` file?
https://github.com/apache/druid/blame/master/dev/teamcity.md#L87
```diff
- If you did everything right, file `.idea/inspectionProfiles/Druid.xml` should be updated with a new
+ If you did everything right, file [`.idea/inspectionProfiles/Druid.xml`](/.idea/inspectionProfiles/Druid.xml) should be updated with a new
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org