You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2020/05/19 13:42:23 UTC
svn commit: r1877919 -
/pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java
Author: tilman
Date: Tue May 19 13:42:23 2020
New Revision: 1877919
URL: http://svn.apache.org/viewvc?rev=1877919&view=rev
Log:
PDFBOX-3017: only the signDetached() call should throw the exception
Modified:
pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java
Modified: pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java?rev=1877919&r1=1877918&r2=1877919&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java (original)
+++ pdfbox/trunk/examples/src/test/java/org/apache/pdfbox/examples/pdmodel/TestCreateSignature.java Tue May 19 13:42:23 2020
@@ -190,11 +190,11 @@ public class TestCreateSignature
String outPath = OUT_DIR + getOutputFileName("signed{0}_tsa.pdf");
// sign PDF (will fail due to nonce and timestamp differing)
+ CreateSignature signing1 = new CreateSignature(keystore, PASSWORD.toCharArray());
+ signing1.setExternalSigning(externallySign);
try
{
- CreateSignature signing = new CreateSignature(keystore, PASSWORD.toCharArray());
- signing.setExternalSigning(externallySign);
- signing.signDetached(new File(inPath), new File(outPath), brokenMockTSA);
+ signing1.signDetached(new File(inPath), new File(outPath), brokenMockTSA);
Assert.fail("This should have failed");
}
catch (IOException e)
@@ -211,9 +211,9 @@ public class TestCreateSignature
return;
}
- CreateSignature signing = new CreateSignature(keystore, PASSWORD.toCharArray());
- signing.setExternalSigning(externallySign);
- signing.signDetached(new File(inPath), new File(outPath), tsa);
+ CreateSignature signing2 = new CreateSignature(keystore, PASSWORD.toCharArray());
+ signing2.setExternalSigning(externallySign);
+ signing2.signDetached(new File(inPath), new File(outPath), tsa);
checkSignature(new File(inPath), new File(outPath));
System.out.println("TSA test successful");
}