[GitHub] [cordova-plugin-network-information] PieterVanPoyer edited a comment on pull request #111: Android - Fixes https://github.com/apache/cordova-plugin-network-information#110

[GitBox <gi...@apache.org>]

PieterVanPoyer edited a comment on pull request #111:
URL: https://github.com/apache/cordova-plugin-network-information/pull/111#issuecomment-640059715


   Hey
   
   Can someone review this, please.
   During the startup procedure, there are also events dispatched, but they are not checked with the equals mechanism (Same as before).
   But IMO sometimes it fires 2 times when starting up the app. 
   I think that's more a job for a Cordova specialist, or we could wait for an issue to be filed.
   
   In the startup routine it is just fired, no check has been done.
   https://github.com/apache/cordova-plugin-network-information/blob/9f8527062776ead04982d7fab12875a66bf69855/src/android/NetworkManager.java#L114-L127
   
   Maybe we should change the documentation and mention that no checks on Android are done when the app is in the background/idle.
   
   Kind regards
   Pieter


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org