You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2018/04/13 05:42:02 UTC
[isis] branch master updated: ISIS-1841 remove compile-warning
suppressions
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 5a5e4f3 ISIS-1841 remove compile-warning suppressions
5a5e4f3 is described below
commit 5a5e4f357b0d02ddfa97ce05fb1a929c7b11fe91
Author: Andi Huber <ah...@apache.org>
AuthorDate: Fri Apr 13 07:41:53 2018 +0200
ISIS-1841 remove compile-warning suppressions
Despite adding to visual cluttering, we provide serialVersionUID where
missing.
---
.../org/apache/isis/applib/IsisApplibModule.java | 61 +++++++++++++---------
.../applib/layout/grid/bootstrap3/BS3ClearFix.java | 5 +-
.../layout/grid/bootstrap3/BS3ElementAbstract.java | 5 +-
.../applib/layout/menubars/MenuBarsAbstract.java | 3 +-
.../mixins/layout/Object_downloadLayoutXml.java | 8 +--
.../applib/mixins/layout/Object_openRestApi.java | 6 ++-
.../mixins/layout/Object_rebuildMetamodel.java | 6 ++-
.../applib/services/layout/LayoutServiceMenu.java | 7 ++-
.../facets/propparam/specification/Utils.java | 2 +-
9 files changed, 62 insertions(+), 41 deletions(-)
diff --git a/core/applib/src/main/java/org/apache/isis/applib/IsisApplibModule.java b/core/applib/src/main/java/org/apache/isis/applib/IsisApplibModule.java
index 9b0b3b5..28c6c3d 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/IsisApplibModule.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/IsisApplibModule.java
@@ -23,31 +23,40 @@ import javax.xml.bind.annotation.XmlRootElement;
@XmlRootElement(name = "module")
public class IsisApplibModule extends ModuleAbstract {
- // -- ui event classes
- @SuppressWarnings("serial") // serial versionId to be provided by concrete class
- public abstract static class TitleUiEvent<S>
- extends org.apache.isis.applib.events.ui.TitleUiEvent<S> { }
- @SuppressWarnings("serial") // serial versionId to be provided by concrete class
- public abstract static class IconUiEvent<S>
- extends org.apache.isis.applib.events.ui.IconUiEvent<S> { }
- @SuppressWarnings("serial") // serial versionId to be provided by concrete class
- public abstract static class CssClassUiEvent<S>
- extends org.apache.isis.applib.events.ui.CssClassUiEvent<S> { }
-
- // -- domain event classes
-
- @SuppressWarnings("serial") // serial versionId to be provided by concrete class
- public abstract static class ActionDomainEvent<S> extends org.apache.isis.applib.events.domain.ActionDomainEvent<S> {
- }
-
- @SuppressWarnings("serial") // serial versionId to be provided by concrete class
- public abstract static class CollectionDomainEvent<S,T> extends org.apache.isis.applib.events.domain.CollectionDomainEvent<S,T> {
- }
-
- @SuppressWarnings("serial") // serial versionId to be provided by concrete class
- public abstract static class PropertyDomainEvent<S,T> extends org.apache.isis.applib.events.domain.PropertyDomainEvent<S,T> {
- }
-
-
+ // -- UI EVENT CLASSES
+
+ public abstract static class TitleUiEvent<S>
+ extends org.apache.isis.applib.events.ui.TitleUiEvent<S> {
+ private static final long serialVersionUID = 1L;
+ }
+
+ public abstract static class IconUiEvent<S>
+ extends org.apache.isis.applib.events.ui.IconUiEvent<S> {
+ private static final long serialVersionUID = 1L;
+ }
+
+ public abstract static class CssClassUiEvent<S>
+ extends org.apache.isis.applib.events.ui.CssClassUiEvent<S> {
+ private static final long serialVersionUID = 1L;
+ }
+
+ // -- DOMAIN EVENT CLASSES
+
+ public abstract static class ActionDomainEvent<S>
+ extends org.apache.isis.applib.events.domain.ActionDomainEvent<S> {
+ private static final long serialVersionUID = 1L;
+ }
+
+ public abstract static class CollectionDomainEvent<S,T>
+ extends org.apache.isis.applib.events.domain.CollectionDomainEvent<S,T> {
+ private static final long serialVersionUID = 1L;
+ }
+
+ public abstract static class PropertyDomainEvent<S,T>
+ extends org.apache.isis.applib.events.domain.PropertyDomainEvent<S,T> {
+ private static final long serialVersionUID = 1L;
+ }
+
+
}
diff --git a/core/applib/src/main/java/org/apache/isis/applib/layout/grid/bootstrap3/BS3ClearFix.java b/core/applib/src/main/java/org/apache/isis/applib/layout/grid/bootstrap3/BS3ClearFix.java
index ce50d68..35d04d6 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/layout/grid/bootstrap3/BS3ClearFix.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/layout/grid/bootstrap3/BS3ClearFix.java
@@ -18,8 +18,9 @@
*/
package org.apache.isis.applib.layout.grid.bootstrap3;
-@SuppressWarnings("serial") // serial versionId to be provided by concrete class
public abstract class BS3ClearFix extends BS3RowContent {
-
+
+ private static final long serialVersionUID = 1L;
+
public abstract String toCssClass();
}
diff --git a/core/applib/src/main/java/org/apache/isis/applib/layout/grid/bootstrap3/BS3ElementAbstract.java b/core/applib/src/main/java/org/apache/isis/applib/layout/grid/bootstrap3/BS3ElementAbstract.java
index 233e261..2a3104a 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/layout/grid/bootstrap3/BS3ElementAbstract.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/layout/grid/bootstrap3/BS3ElementAbstract.java
@@ -23,10 +23,11 @@ import javax.xml.bind.annotation.XmlAttribute;
/**
* Superclass for all layout classes, factoring out the common {@link #getCssClass()} attribute.
*/
-@SuppressWarnings("serial") // serial versionId to be provided by concrete class
public abstract class BS3ElementAbstract implements BS3Element {
+
+ private static final long serialVersionUID = 1L;
- private String cssClass;
+ private String cssClass;
/**
* Any additional CSS classes to render on the page element corresponding to this object,
diff --git a/core/applib/src/main/java/org/apache/isis/applib/layout/menubars/MenuBarsAbstract.java b/core/applib/src/main/java/org/apache/isis/applib/layout/menubars/MenuBarsAbstract.java
index 5c45fbe..2e4026b 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/layout/menubars/MenuBarsAbstract.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/layout/menubars/MenuBarsAbstract.java
@@ -27,10 +27,11 @@ import org.apache.isis.applib.annotation.Programmatic;
import org.apache.isis.applib.internal.collections._Maps;
import org.apache.isis.applib.layout.component.ServiceActionLayoutData;
-@SuppressWarnings("serial") // serial versionId to be provided by concrete class
@XmlTransient // ignore this class
public abstract class MenuBarsAbstract implements MenuBars, Serializable {
+ private static final long serialVersionUID = 1L;
+
private String tnsAndSchemaLocation;
@Programmatic
diff --git a/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_downloadLayoutXml.java b/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_downloadLayoutXml.java
index 3306c3b..73417c5 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_downloadLayoutXml.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_downloadLayoutXml.java
@@ -29,16 +29,18 @@ import org.apache.isis.applib.services.layout.LayoutService;
import org.apache.isis.applib.value.Clob;
@Mixin(method="act")
-@SuppressWarnings("serial")
public class Object_downloadLayoutXml {
-
+
private final Object object;
public Object_downloadLayoutXml(final Object object) {
this.object = object;
}
- public static class ActionDomainEvent extends org.apache.isis.applib.IsisApplibModule.ActionDomainEvent<Object_downloadLayoutXml> {}
+ public static class ActionDomainEvent
+ extends org.apache.isis.applib.IsisApplibModule.ActionDomainEvent<Object_downloadLayoutXml> {
+ private static final long serialVersionUID = 1L;
+ }
@Action(
domainEvent = ActionDomainEvent.class,
diff --git a/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_openRestApi.java b/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_openRestApi.java
index 922e69c..0d6990b 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_openRestApi.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_openRestApi.java
@@ -30,7 +30,6 @@ import org.apache.isis.applib.services.swagger.SwaggerService;
import org.apache.isis.applib.value.LocalResourcePath;
@Mixin(method="act")
-@SuppressWarnings("serial")
public class Object_openRestApi {
private final Object object;
@@ -39,7 +38,10 @@ public class Object_openRestApi {
this.object = object;
}
- public static class ActionDomainEvent extends org.apache.isis.applib.IsisApplibModule.ActionDomainEvent<Object_openRestApi> {}
+ public static class ActionDomainEvent
+ extends org.apache.isis.applib.IsisApplibModule.ActionDomainEvent<Object_openRestApi> {
+ private static final long serialVersionUID = 1L;
+ }
@Action(
domainEvent = ActionDomainEvent.class,
diff --git a/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_rebuildMetamodel.java b/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_rebuildMetamodel.java
index aa526b2..0db5dc0 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_rebuildMetamodel.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/mixins/layout/Object_rebuildMetamodel.java
@@ -27,7 +27,6 @@ import org.apache.isis.applib.annotation.SemanticsOf;
import org.apache.isis.applib.services.metamodel.MetaModelService;
@Mixin(method="act")
-@SuppressWarnings("serial")
public class Object_rebuildMetamodel {
private final Object object;
@@ -36,7 +35,10 @@ public class Object_rebuildMetamodel {
this.object = object;
}
- public static class ActionDomainEvent extends org.apache.isis.applib.IsisApplibModule.ActionDomainEvent<Object_rebuildMetamodel> {}
+ public static class ActionDomainEvent
+ extends org.apache.isis.applib.IsisApplibModule.ActionDomainEvent<Object_rebuildMetamodel> {
+ private static final long serialVersionUID = 1L;
+ }
@Action(
domainEvent = ActionDomainEvent.class,
diff --git a/core/applib/src/main/java/org/apache/isis/applib/services/layout/LayoutServiceMenu.java b/core/applib/src/main/java/org/apache/isis/applib/services/layout/LayoutServiceMenu.java
index 3373db4..4a3b930 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/services/layout/LayoutServiceMenu.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/services/layout/LayoutServiceMenu.java
@@ -43,10 +43,11 @@ import org.apache.isis.applib.value.Clob;
menuBar = DomainServiceLayout.MenuBar.SECONDARY,
menuOrder = "500.400"
)
-@SuppressWarnings("serial")
public class LayoutServiceMenu {
- public static abstract class ActionDomainEvent extends IsisApplibModule.ActionDomainEvent<LayoutServiceMenu> {
+ public static abstract class ActionDomainEvent
+ extends IsisApplibModule.ActionDomainEvent<LayoutServiceMenu> {
+ private static final long serialVersionUID = 1L;
}
private final MimeType mimeTypeApplicationZip;
@@ -60,6 +61,7 @@ public class LayoutServiceMenu {
}
public static class DownloadLayoutsDomainEvent extends ActionDomainEvent {
+ private static final long serialVersionUID = 1L;
}
@Action(
@@ -85,6 +87,7 @@ public class LayoutServiceMenu {
}
public static class DownloadMenuBarsLayoutDomainEvent extends ActionDomainEvent {
+ private static final long serialVersionUID = 1L;
}
@Action(
diff --git a/core/metamodel/src/test/java/org/apache/isis/core/metamodel/facets/propparam/specification/Utils.java b/core/metamodel/src/test/java/org/apache/isis/core/metamodel/facets/propparam/specification/Utils.java
index 85309bf..4ccea41 100644
--- a/core/metamodel/src/test/java/org/apache/isis/core/metamodel/facets/propparam/specification/Utils.java
+++ b/core/metamodel/src/test/java/org/apache/isis/core/metamodel/facets/propparam/specification/Utils.java
@@ -29,7 +29,7 @@ public final class Utils {
private Utils() {
}
- @SuppressWarnings("serial")
+
public static List<Specification> listOf(final Specification specification) {
return new ArrayList<Specification>() {
{
--
To stop receiving notification emails like this one, please contact
ahuber@apache.org.