You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Balu Vellanki <bv...@hortonworks.com> on 2015/09/16 16:41:50 UTC
Re: Review Request 38391: Simple validation for entity properties
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38391/
-----------------------------------------------------------
(Updated Sept. 16, 2015, 2:41 p.m.)
Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
Changes
-------
Included suggestions made by Sowmya in the new patch.
Summary (updated)
-----------------
Simple validation for entity properties
Bugs: FALCON-1342
https://issues.apache.org/jira/browse/FALCON-1342
Repository: falcon-git
Description
-------
When specifying properties for a cluster, this is currently allowed,
{code}
<properties>
<property name="test" value="value1"/>
<property name="test" value="value2"/>
</properties>
{code}
The propeties are stored as an array of org.apache.falcon.entity.v0.cluster.Property, and cluster.getProperty("test") will return either "value1" or "value2" but not both. If falcon does not support multiple values for same property key, parsing such an entity should throw an error.
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84
common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java f22a343
common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java 56cc4ca
common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java 638cef9
common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java 754fb06
common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java 6612b74
common/src/test/resources/config/feed/feed-0.1.xml 6448803
Diff: https://reviews.apache.org/r/38391/diff/
Testing
-------
Added unit test. Tested end2end
Thanks,
Balu Vellanki
Re: Review Request 38391: Simple validation for entity properties
Posted by Sowmya Ramesh <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38391/#review99269
-----------------------------------------------------------
Ship it!
Ship It!
- Sowmya Ramesh
On Sept. 16, 2015, 2:41 p.m., Balu Vellanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38391/
> -----------------------------------------------------------
>
> (Updated Sept. 16, 2015, 2:41 p.m.)
>
>
> Review request for Falcon, Pallavi Rao, Sowmya Ramesh, and Venkat Ranganathan.
>
>
> Bugs: FALCON-1342
> https://issues.apache.org/jira/browse/FALCON-1342
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> When specifying properties for a cluster, this is currently allowed,
>
> {code}
> <properties>
> <property name="test" value="value1"/>
> <property name="test" value="value2"/>
> </properties>
> {code}
>
> The propeties are stored as an array of org.apache.falcon.entity.v0.cluster.Property, and cluster.getProperty("test") will return either "value1" or "value2" but not both. If falcon does not support multiple values for same property key, parsing such an entity should throw an error.
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/entity/parser/ClusterEntityParser.java 5756f84
> common/src/main/java/org/apache/falcon/entity/parser/FeedEntityParser.java f22a343
> common/src/main/java/org/apache/falcon/entity/parser/ProcessEntityParser.java 56cc4ca
> common/src/test/java/org/apache/falcon/entity/parser/ClusterEntityParserTest.java 638cef9
> common/src/test/java/org/apache/falcon/entity/parser/FeedEntityParserTest.java 754fb06
> common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java 6612b74
> common/src/test/resources/config/feed/feed-0.1.xml 6448803
>
> Diff: https://reviews.apache.org/r/38391/diff/
>
>
> Testing
> -------
>
> Added unit test. Tested end2end
>
>
> Thanks,
>
> Balu Vellanki
>
>