[GitHub] [flink] dawidwys commented on issue #10915: [FLINK-15706][table-planner-blink] Not use Arrays.asList to avoid incompatible error

[GitBox <gi...@apache.org>]

dawidwys commented on issue #10915: [FLINK-15706][table-planner-blink] Not use Arrays.asList to avoid incompatible error
URL: https://github.com/apache/flink/pull/10915#issuecomment-577622240
 
 
   I don't think this is a valid solution. I would not merge this PR as it could just potentially make it even harder to track back the problem.
   
   What I would definitely suggest is to remove the generic parameter from the class `LastValueAggFunctionWithOrderTest` as it is wrong there and tbh it's hard to say to what type it is inferred to. Most probably it's always `Object` 
   
   Also it would make much sense to flatten the structure of those tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services