[GitHub] style95 commented on a change in pull request #1790: Make OW run with docker for mac

[gi...@git.apache.org]

style95 commented on a change in pull request #1790: Make OW run with docker for mac
URL: https://github.com/apache/incubator-openwhisk/pull/1790#discussion_r124366740
 
 

 ##########
 File path: ansible/environments/mac/group_vars/all
 ##########
 @@ -4,11 +4,6 @@ whisk_logs_dir: /Users/Shared/wsklogs
 docker_registry: ""
 docker_dns: ""
 
-# The whisk_api_localhost_name is used to configure nginx to permit vanity URLs for web actions.
-# It is also used for the SSL certificate generation. For a local deployment, this is typically
-# a hostname that is resolved on the client, via /etc/hosts for example.
-whisk_api_localhost_name: "openwhisk"
 
 Review comment:
   With this pr, `mac` environment is for Docker for Mac, and Ansible can deploy OW on Mac with configurations in `local` environment.
   So I copied `group_vars/all` from local environment.
   
   AFAIK, Ansible can not deploy OW without that option in `docker-machine` env, but in `mac` env, it does not.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services