You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Tzu-Li (Gordon) Tai (JIRA)" <ji...@apache.org> on 2018/01/13 08:12:00 UTC

[jira] [Closed] (FLINK-8296) Rework FlinkKafkaConsumerBestTest to not use Java reflection for dependency injection

     [ https://issues.apache.org/jira/browse/FLINK-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tzu-Li (Gordon) Tai closed FLINK-8296.
--------------------------------------
    Resolution: Fixed

> Rework FlinkKafkaConsumerBestTest to not use Java reflection for dependency injection
> -------------------------------------------------------------------------------------
>
>                 Key: FLINK-8296
>                 URL: https://issues.apache.org/jira/browse/FLINK-8296
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector, Tests
>            Reporter: Tzu-Li (Gordon) Tai
>            Assignee: Tzu-Li (Gordon) Tai
>             Fix For: 1.5.0, 1.4.1
>
>
> The current {{FlinkKafkaConsumerBaseTest}} is heavily relying on Java reflection for dependency injection. Using reflection to compose unit tests really should be a last resort, and indicates that the tests there are highly implementation-specific, and that we should make the design more testable.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)