You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@thrift.apache.org by "kpumuk (via GitHub)" <gi...@apache.org> on 2026/07/26 19:12:41 UTC

[PR] THRIFT-6122: Normalize Ruby JSON Unicode handling [thrift]

kpumuk opened a new pull request, #3673:
URL: https://github.com/apache/thrift/pull/3673

   <!-- Explain the changes in the pull request below: -->
     
   The Ruby JSON protocol interprets every `\uXXXX` escape independently, so supplementary Unicode characters represented as UTF-16 surrogate pairs fail before the two code units can be combined. It also writes strings using the caller's declared encoding, which can place non-UTF-8 bytes in a JSON payload.
   
   This change combines valid surrogate pairs into their Unicode scalar value and reports malformed escapes or unpaired surrogates as typed protocol errors. When writing, it preserves valid UTF-8, accepts valid UTF-8 bytes carried by binary Ruby strings, transcodes strings with another declared encoding, and rejects invalid byte sequences before emitting any JSON bytes. The caller's string is left unchanged.
   
   <!-- We recommend you review the checklist/tips before submitting a pull request. -->
   
   - [x] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? [THRIFT-6122](https://issues.apache.org/jira/browse/THRIFT-6122)
   - [x] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
   - [x] Did you squash your changes to a single commit?  (not required, but preferred)
   - [x] Did you do your best to avoid breaking changes?  If one was needed, did you label the Jira ticket with "Breaking-Change"?
   - [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
   
   <!--
     The Contributing Guide at:
     https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
     has more details and tips for committing properly.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] THRIFT-6122: Normalize Ruby JSON Unicode handling [thrift]

Posted by "kpumuk (via GitHub)" <gi...@apache.org>.
kpumuk merged PR #3673:
URL: https://github.com/apache/thrift/pull/3673


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org