You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tooling.apache.org by "andrewmusselman (via GitHub)" <gi...@apache.org> on 2026/02/19 06:38:37 UTC

[I] Implement JWT token revocation mechanism (tooling-trusted-releases)

andrewmusselman opened a new issue, #732:
URL: https://github.com/apache/tooling-trusted-releases/issues/732

   **ASVS References:** 7.2.4, 7.4.1, 7.4.2
   
   **Findings:** 7.2.4-03, 7.2.4-04, 7.4.1-HIGH-001, 7.4.2-04
   
   ### Description
   
   JWT tokens are issued with a `jti` (JWT ID) claim, but this value is never stored or checked against a revocation list. Once issued, a JWT remains valid until its natural 30-minute expiration regardless of:
   
   - User logout
   - PAT deletion (the PAT used to obtain the JWT)
   - Account disable/deactivation
   - Suspected compromise
   
   Multiple valid JWTs can accumulate for the same user with no way to invalidate them.
   
   ### Affected Endpoints
   
   All endpoints protected by `@jwtoken.require`, including `/api/release/create`, `/api/release/upload`, `/api/key/add`, `/api/ssh-key/add`, `/api/vote/start`, and others.
   
   ### Affected Files
   
   - `atr/jwtoken.py` — `issue()` generates `jti` but never tracks it; `verify()` has no revocation check
   - `atr/storage/writers/tokens.py` — `issue_jwt()` and `delete_token()` don't interact with revocation
   - `atr/post/tokens.py` — JWT issuance endpoint
   
   ### Recommendation
   
   Add a page to expire all JWTs
   
   Also: when a PAT is deleted, any JWTs derived from it should be revoked (cross-ref finding 7.2.4-05). (@sbp should this be another issue?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Implement JWT token revocation mechanism (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp closed issue #732: Implement JWT token revocation mechanism
URL: https://github.com/apache/tooling-trusted-releases/issues/732


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org


Re: [I] Implement JWT token revocation mechanism (tooling-trusted-releases)

Posted by "sbp (via GitHub)" <gi...@apache.org>.
sbp commented on issue #732:
URL: https://github.com/apache/tooling-trusted-releases/issues/732#issuecomment-4007521146

   Resolved by 67efe112bbaf2ed001d422b10727df83434547b6. Opened #828 to track the secondary issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tooling.apache.org
For additional commands, e-mail: dev-help@tooling.apache.org