You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Adam Szita via Review Board <no...@reviews.apache.org> on 2018/01/23 09:42:51 UTC
Review Request 65285: Create tests to cover getPartition(s) methods
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/
-----------------------------------------------------------
Review request for hive, Marta Kuczora and Peter Vary.
Bugs: HIVE-18483
https://issues.apache.org/jira/browse/HIVE-18483
Repository: hive-git
Description
-------
Create tests to cover getPartition(s) methods
Diffs
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java PRE-CREATION
Diff: https://reviews.apache.org/r/65285/diff/1/
Testing
-------
Thanks,
Adam Szita
Re: Review Request 65285: Create tests to cover getPartition(s)
methods
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/#review195995
-----------------------------------------------------------
Thanks a lot Adam for the patch. It looks very good to me.
- Marta Kuczora
On Jan. 23, 2018, 9:42 a.m., Adam Szita wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65285/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2018, 9:42 a.m.)
>
>
> Review request for hive, Marta Kuczora and Peter Vary.
>
>
> Bugs: HIVE-18483
> https://issues.apache.org/jira/browse/HIVE-18483
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Create tests to cover getPartition(s) methods
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65285/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam Szita
>
>
Re: Review Request 65285: Create tests to cover getPartition(s)
methods
Posted by Adam Szita via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/
-----------------------------------------------------------
(Updated Jan. 25, 2018, 1:51 p.m.)
Review request for hive, Marta Kuczora and Peter Vary.
Bugs: HIVE-18483
https://issues.apache.org/jira/browse/HIVE-18483
Repository: hive-git
Description
-------
Create tests to cover getPartition(s) methods
Diffs (updated)
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java PRE-CREATION
Diff: https://reviews.apache.org/r/65285/diff/3/
Changes: https://reviews.apache.org/r/65285/diff/2-3/
Testing
-------
Thanks,
Adam Szita
Re: Review Request 65285: Create tests to cover getPartition(s)
methods
Posted by Marta Kuczora via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/#review196223
-----------------------------------------------------------
Ship it!
Ship It!
- Marta Kuczora
On Jan. 24, 2018, 2:02 p.m., Adam Szita wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65285/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 2:02 p.m.)
>
>
> Review request for hive, Marta Kuczora and Peter Vary.
>
>
> Bugs: HIVE-18483
> https://issues.apache.org/jira/browse/HIVE-18483
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Create tests to cover getPartition(s) methods
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65285/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam Szita
>
>
Re: Review Request 65285: Create tests to cover getPartition(s)
methods
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/#review196234
-----------------------------------------------------------
Ship it!
Ship It!
- Peter Vary
On Jan. 24, 2018, 2:02 p.m., Adam Szita wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65285/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 2:02 p.m.)
>
>
> Review request for hive, Marta Kuczora and Peter Vary.
>
>
> Bugs: HIVE-18483
> https://issues.apache.org/jira/browse/HIVE-18483
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Create tests to cover getPartition(s) methods
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65285/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam Szita
>
>
Re: Review Request 65285: Create tests to cover getPartition(s)
methods
Posted by Adam Szita via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/
-----------------------------------------------------------
(Updated Jan. 24, 2018, 2:02 p.m.)
Review request for hive, Marta Kuczora and Peter Vary.
Changes
-------
Addressed review comments
Bugs: HIVE-18483
https://issues.apache.org/jira/browse/HIVE-18483
Repository: hive-git
Description
-------
Create tests to cover getPartition(s) methods
Diffs (updated)
-----
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java PRE-CREATION
Diff: https://reviews.apache.org/r/65285/diff/2/
Changes: https://reviews.apache.org/r/65285/diff/1-2/
Testing
-------
Thanks,
Adam Szita
Re: Review Request 65285: Create tests to cover getPartition(s)
methods
Posted by Adam Szita via Review Board <no...@reviews.apache.org>.
> On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
> > Lines 200 (patched)
> > <https://reviews.apache.org/r/65285/diff/1/?file=1944365#file1944365line200>
> >
> > Maybe test for case insensitivity?
Added test case
> On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
> > Lines 236 (patched)
> > <https://reviews.apache.org/r/65285/diff/1/?file=1944365#file1944365line236>
> >
> > Maybe test for no db?
Added test case
> On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
> > Lines 305 (patched)
> > <https://reviews.apache.org/r/65285/diff/1/?file=1944365#file1944365line305>
> >
> > Maybe test for no database?
Added test case
> On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote:
> > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
> > Lines 347 (patched)
> > <https://reviews.apache.org/r/65285/diff/1/?file=1944365#file1944365line347>
> >
> > Maybe test for case insensitivity?
Added test case
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/#review196018
-----------------------------------------------------------
On Jan. 24, 2018, 2:02 p.m., Adam Szita wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65285/
> -----------------------------------------------------------
>
> (Updated Jan. 24, 2018, 2:02 p.m.)
>
>
> Review request for hive, Marta Kuczora and Peter Vary.
>
>
> Bugs: HIVE-18483
> https://issues.apache.org/jira/browse/HIVE-18483
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Create tests to cover getPartition(s) methods
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65285/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam Szita
>
>
Re: Review Request 65285: Create tests to cover getPartition(s)
methods
Posted by Peter Vary via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65285/#review196018
-----------------------------------------------------------
Just 2 more test cases I can come up with.
Is it worth to create a test case for them?
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Lines 200 (patched)
<https://reviews.apache.org/r/65285/#comment275537>
Maybe test for case insensitivity?
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Lines 236 (patched)
<https://reviews.apache.org/r/65285/#comment275538>
Maybe test for no db?
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Lines 305 (patched)
<https://reviews.apache.org/r/65285/#comment275539>
Maybe test for no database?
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java
Lines 347 (patched)
<https://reviews.apache.org/r/65285/#comment275540>
Maybe test for case insensitivity?
- Peter Vary
On Jan. 23, 2018, 9:42 a.m., Adam Szita wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65285/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2018, 9:42 a.m.)
>
>
> Review request for hive, Marta Kuczora and Peter Vary.
>
>
> Bugs: HIVE-18483
> https://issues.apache.org/jira/browse/HIVE-18483
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Create tests to cover getPartition(s) methods
>
>
> Diffs
> -----
>
> standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65285/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Adam Szita
>
>