[jira] [Commented] (SAMZA-230) Fix Integer warnings post SAMZA-223

["David Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988701#comment-13988701 ] 

David Chen commented on SAMZA-230:
----------------------------------

RB: https://reviews.apache.org/r/21053/

This was a trivial change. The above is the only instance of this warning that I found. I simply changed the {{Integer}} to {{Int}}.

I validated the change by building against both Scala 2.9.2 and Scala 2.10. Other than the known {{testShouldStartAndRestore}} issue reported in SAMZA-224, there were no build issues and the unit tests pass.

> Fix Integer warnings post SAMZA-223
> -----------------------------------
>
>                 Key: SAMZA-230
>                 URL: https://issues.apache.org/jira/browse/SAMZA-230
>             Project: Samza
>          Issue Type: Task
>    Affects Versions: 0.7.0
>            Reporter: Jakob Homan
>            Assignee: David Chen
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.7.0
>
>         Attachments: 0001-SAMZA-230-Fix-compiler-warning-by-using-Int-instead-.patch
>
>
> After SAMZA-223, the check task (for Scala 2.9.2) complains about the deprecated usage of Integer rather than java.lang.Integer.
> {noformat}[ant:scalac] /Users/jhoman/repos/samza/samza-core/src/main/scala/org/apache/samza/system/StreamMetadataCache.scala:38: warning: type Integer is deprecated: use java.lang.Integer instead
> [ant:scalac]     val cacheTTLms: Integer = 5000,
> ...
> /Users/jhoman/repos/samza/samza-core/src/test/scala/org/apache/samza/system/TestStreamMetadataCache.scala:59: warning: type Integer is deprecated: use java.lang.Integer instead
>     val cache = new StreamMetadataCache(systemAdmins = systemAdmins, clock = clock){noformat}
> Should just use Int as these classes don't need to play nice with Java.



--
This message was sent by Atlassian JIRA
(v6.2#6252)