[GitHub] [kafka] clolov commented on a diff in pull request #13099: KAFKA-14604: avoid SASL session expiration time overflowed when calculation

[GitBox <gi...@apache.org>]

clolov commented on code in PR #13099:
URL: https://github.com/apache/kafka/pull/13099#discussion_r1073321039


##########
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##########
@@ -1496,4 +1496,32 @@ public static String replaceSuffix(String str, String oldSuffix, String newSuffi
             throw new IllegalArgumentException("Expected string to end with " + oldSuffix + " but string is " + str);
         return str.substring(0, str.length() - oldSuffix.length()) + newSuffix;
     }
+
+    public static long zeroIfNegative(long value) {
+        return Math.max(0L, value);
+    }
+
+    // returns the sum of a and b unless it would overflow, which will return Long.MAX_VALUE
+    public static long saturatedAdd(long a, long b) {
+        long result = Long.MAX_VALUE;
+        try {
+            result = Math.addExact(a, b);
+        } catch (ArithmeticException e) {
+            log.info("The sum of {} and {} is overflowed, set to Long.MAX_VALUE", a, b);

Review Comment:
   Following Ismael's comment, isn't it wiser to also put an upper bound on https://kafka.apache.org/documentation/#brokerconfigs_connections.max.reauth.ms? As far as I understand the documentation if a client wants to never be forced to reauthenticate they need to just use the default value of 0?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org