[GitHub] [druid] tonyschwartz opened a new pull request #8813: OpenJDK historical segment hand-off fails with Illegal Field Name error

[GitBox <gi...@apache.org>]

tonyschwartz opened a new pull request #8813: OpenJDK historical segment hand-off fails with Illegal Field Name error
URL: https://github.com/apache/druid/pull/8813
 
 
   ### Description
   While trying to use Druid (apache incubating) on OpenJDK (I have tried to run it with the latest 8 and 11 versions of OpenJDK), everything seems to work well, but when the segments go to be handed off to the "historical" segment manager (I'm not sure of the details of this), the app fails.  All my segments then become "unavailable".  coordinator-overlord.log shows this error:
   2019-10-31T16:23:02,953 ERROR
   [LeaderSelector[/druid/coordinator/_COORDINATOR]]
   org.apache.curator.framework.listen.ListenerContainer - Listener
   (org.apache.druid.curator.discovery.CuratorDruidLeaderSelector$1@1e7d3d87
   )
   threw an exception
   java.lang.ClassFormatError: Illegal field name
   "org.apache.druid.server.coordinator.DruidCoordinator$this" in class
   
   
   <!-- Describe your patch: what did you change in code? How did you fix the problem? -->
   a code change to:  DruidCoordinator.java @line 690.  the instance inner
   class CoordinatorHistoricalManagerRunnable has a constructor that is
   referencing DruidCoordinator.this prior to the super(...) constructor
   call completing.  This causes a failure.  A work-around is to pass the
   coordinator
   instance to the constructor:
   CoordinatorHistoricalManagerRunnable(final DruidCoordinator druidCoordinator, final int
   startingLeaderCounter)
   and then, reference druidCoordinator instead of DruidCoordinator.this throughout that
   constructor.  
   
   
   <hr>
   
   ##### Key changed/added classes in this PR
    * `DruidCoordinator.CoordinatorHistoricalManagerRunnable`
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org