You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/13 19:55:16 UTC
[GitHub] [yunikorn-core] craigcondit opened a new pull request, #477: [YUNIKORN-1454] Add new queue properties for priority
craigcondit opened a new pull request, #477:
URL: https://github.com/apache/yunikorn-core/pull/477
### What is this PR for?
Add support for new queue configuration properties related to priority support.
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [x] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1454
### How should this be tested?
Unit tests added / updated.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #477: [YUNIKORN-1454] Add new queue properties for priority
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #477:
URL: https://github.com/apache/yunikorn-core/pull/477#issuecomment-1349611833
# [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/477?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#477](https://codecov.io/gh/apache/yunikorn-core/pull/477?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03e93c2) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/24fceecbee525dbb58479587346f23e9c676e0e4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (24fceec) will **increase** coverage by `0.19%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 72.52% 72.72% +0.19%
==========================================
Files 67 69 +2
Lines 10114 10187 +73
==========================================
+ Hits 7335 7408 +73
Misses 2533 2533
Partials 246 246
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/common/configs/configvalidator.go](https://codecov.io/gh/apache/yunikorn-core/pull/477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9jb25maWdzL2NvbmZpZ3ZhbGlkYXRvci5nbw==) | `86.62% <ø> (ø)` | |
| [pkg/scheduler/objects/queue.go](https://codecov.io/gh/apache/yunikorn-core/pull/477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3F1ZXVlLmdv) | `72.37% <100.00%> (+1.53%)` | :arrow_up: |
| [pkg/scheduler/policies/preemption\_policy.go](https://codecov.io/gh/apache/yunikorn-core/pull/477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wb2xpY2llcy9wcmVlbXB0aW9uX3BvbGljeS5nbw==) | `100.00% <100.00%> (ø)` | |
| [pkg/scheduler/policies/priority\_policy.go](https://codecov.io/gh/apache/yunikorn-core/pull/477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9wb2xpY2llcy9wcmlvcml0eV9wb2xpY3kuZ28=) | `100.00% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] craigcondit closed pull request #477: [YUNIKORN-1454] Add new queue properties for priority
Posted by GitBox <gi...@apache.org>.
craigcondit closed pull request #477: [YUNIKORN-1454] Add new queue properties for priority
URL: https://github.com/apache/yunikorn-core/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org