You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/09 19:48:40 UTC

[GitHub] [spark] viirya edited a comment on pull request #33068: [SPARK-36461][SQL] Enable ObjectHashAggregate for more Aggregate functions

viirya edited a comment on pull request #33068:
URL: https://github.com/apache/spark/pull/33068#issuecomment-895477606


   Actually we already have `spark.sql.execution.useObjectHashAggregateExec` to control the use of `ObjectHashAggregateExec`. It sounds a bit redundant to add another config here.
   
   I also think the current condition `TypedImperativeAggregate` is already more strict than others like `ImperativeAggregate` and `DeclarativeAggregate` regarding memory usage.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org