You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2018/08/27 17:36:04 UTC

[Impala-ASF-CR] update Flask to latest (1.0.2)

Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11335


Change subject: update Flask to latest (1.0.2)
......................................................................

update Flask to latest (1.0.2)

Similar to Fabric and Paramiko, make Flask part of extended test
requirements and upgrade it to its latest.

Testing:
- Impala builds, can do a full data load.
- Change works in my local environment.

Change-Id: Ibfc01d562e4d7fe48443d15074bd4c7d0176d2a0
---
M infra/python/deps/extended-test-requirements.txt
M infra/python/deps/requirements.txt
M tests/comparison/leopard/front_end.py
3 files changed, 9 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/35/11335/1
-- 
To view, visit http://gerrit.cloudera.org:8080/11335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibfc01d562e4d7fe48443d15074bd4c7d0176d2a0
Gerrit-Change-Number: 11335
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] update Flask to latest (1.0.2)

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/11335 )

Change subject: update Flask to latest (1.0.2)
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/11335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc01d562e4d7fe48443d15074bd4c7d0176d2a0
Gerrit-Change-Number: 11335
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Aug 2018 17:38:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] update Flask to latest (1.0.2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11335 )

Change subject: update Flask to latest (1.0.2)
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/490/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/11335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc01d562e4d7fe48443d15074bd4c7d0176d2a0
Gerrit-Change-Number: 11335
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Aug 2018 18:09:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] update Flask to latest (1.0.2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11335 )

Change subject: update Flask to latest (1.0.2)
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/11335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc01d562e4d7fe48443d15074bd4c7d0176d2a0
Gerrit-Change-Number: 11335
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Aug 2018 21:01:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] update Flask to latest (1.0.2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11335 )

Change subject: update Flask to latest (1.0.2)
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3087/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/11335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfc01d562e4d7fe48443d15074bd4c7d0176d2a0
Gerrit-Change-Number: 11335
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Aug 2018 17:44:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] update Flask to latest (1.0.2)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11335 )

Change subject: update Flask to latest (1.0.2)
......................................................................

update Flask to latest (1.0.2)

Similar to Fabric and Paramiko, make Flask part of extended test
requirements and upgrade it to its latest.

Testing:
- Impala builds, can do a full data load.
- Change works in my local environment.

Change-Id: Ibfc01d562e4d7fe48443d15074bd4c7d0176d2a0
Reviewed-on: http://gerrit.cloudera.org:8080/11335
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M infra/python/deps/extended-test-requirements.txt
M infra/python/deps/requirements.txt
M tests/comparison/leopard/front_end.py
3 files changed, 9 insertions(+), 6 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/11335
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfc01d562e4d7fe48443d15074bd4c7d0176d2a0
Gerrit-Change-Number: 11335
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>