[GitHub] [nifi-registry] kevdoran commented on issue #162: NIFIREG-238: Allow aliasing of registry url

[GitBox <gi...@apache.org>]

kevdoran commented on issue #162: NIFIREG-238: Allow aliasing of registry url
URL: https://github.com/apache/nifi-registry/pull/162#issuecomment-482601480
 
 
   @brosander That's fair, those are good reasons. I admit I had not considered order in this case.
   
   FWIW, Identity Mappings are also order dependent and are sorted alpha-numerically based on the "key/name" portion of the property. I agree it is not intuitive in that case either (though it is also something that users have been exposed to since Identity Mappings were introduced in NiFi).
   
   If/when we have a chance to do a larger configuration refactoring with breaking changes, I'd suggest we look closely at this. I've seen a lot of ways projects manage order-dependent properties, including: 
   
   1. alpha-numeric sorting of the property keys that make up the collection
   2. preserving order of properties set in the properties file (requires a custom Properties loader)
   3. using array index format, such as:
   
   ```
   nifi.registry.aliases[0].internal = INTERNAL_NIFI_REGISTRY_TOKEN
   nifi.registry.aliases[0].external = https://my.new.secure.registry.url:18443 
   nifi.registry.aliases[1].internal = http://my.old.insecure.registry.url:18080
   nifi.registry.aliases[1].external = https://my.new.secure.registry.url:18443
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services