[GitHub] ccollins476ad commented on issue #142: semver reporting in image list is not consistent

[GitBox <gi...@apache.org>]

ccollins476ad commented on issue #142: semver reporting in image list is not consistent
URL: https://github.com/apache/mynewt-newt/issues/142#issuecomment-380894190
 
 
   When constructing the version string, the firmware intentionally excludes the build ID if it is 0:
   ```
   int
   imgr_ver_str(struct image_version *ver, char *dst)
   {
       if (ver->iv_build_num) {
           return sprintf(dst, "%u.%u.%u.%lu",
             ver->iv_major, ver->iv_minor, ver->iv_revision,
             (unsigned long)ver->iv_build_num);
       } else {
           return sprintf(dst, "%u.%u.%u",
             ver->iv_major, ver->iv_minor, ver->iv_revision);
       }
   }
   ```
   
   @mkiiskila , I know it has been a while, but do you recall the reason for doing this?  Any reason it would be a bad idea to change this to always generate a uniform `#.#.#.#` string?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services