[GitHub] [lucene-solr] risdenk commented on a change in pull request #1076: SOLR-14048: Improve Hadoop test sanity checks

[GitBox <gi...@apache.org>]

risdenk commented on a change in pull request #1076: SOLR-14048: Improve Hadoop test sanity checks
URL: https://github.com/apache/lucene-solr/pull/1076#discussion_r357208260
 
 

 ##########
 File path: solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsTestUtil.java
 ##########
 @@ -87,6 +99,23 @@ private static void checkHadoopWindows() {
         !Constants.WINDOWS || NativeIO.isAvailable());
   }
 
+  /**
+   * Ensure that the tests are picking up the modified Hadoop classes
+   */
+  private static void checkOverriddenHadoopClasses() {
+    List<Class<?>> modifiedHadoopClasses = Arrays.asList(BlockPoolSlice.class, DiskChecker.class,
 
 Review comment:
   Hmm well I didn't know that was an option. I don't think adding the new field is really that bad. We already modified the classes enough adding a specific field that jumps out that we added it shouldn't matter.
   
   The only case I can think of that wouldn't be caught is a new modified Hadoop class. I would bet that in 95% of cases, if one class is messed up on the classpath then all of them will be. SOLR-14047 should also provide a decent amount of protection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org