[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #25: [FLINK-26356] Use the common method to construct service name

[GitBox <gi...@apache.org>]

wangyang0918 commented on a change in pull request #25:
URL: https://github.com/apache/flink-kubernetes-operator/pull/25#discussion_r815569944



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/FlinkService.java
##########
@@ -107,7 +108,11 @@ public void submitSessionCluster(FlinkDeployment deployment, Configuration conf)
         final int port = config.getInteger(RestOptions.PORT);
         final String host =
                 config.getString(
-                        RestOptions.ADDRESS, String.format("%s-rest.%s", clusterId, namespace));
+                        RestOptions.ADDRESS,

Review comment:
       Currently, the `RestOptions.ADDRESS` is always null in effective configuration. So we could simply always use the rest service name here. Right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org