You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/07/13 19:38:59 UTC
[GitHub] [geode] DonalEvans opened a new pull request #6698: GEODE-9424: Accept Long arguments for Redis commands
DonalEvans opened a new pull request #6698:
URL: https://github.com/apache/geode/pull/6698
- Do not return errors when arguments are specified that are less than
Integer.MIN_VALUE or less than Integer.MAX_VALE
- Convert long arguments outside the above range to Integer.MIN_VALUE
or Integer.MAX_VALUE to be used internally
- Add tests for new Coder method and coverage for existing supported
commands that take integer arguments, except HSCAN which will require
GEODE-9429 to be fixed first
Authored-by: Donal Evans <do...@vmware.com>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans merged pull request #6698: GEODE-9424: Accept Long arguments for Redis commands
Posted by GitBox <gi...@apache.org>.
DonalEvans merged pull request #6698:
URL: https://github.com/apache/geode/pull/6698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org