You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2005/05/19 09:17:06 UTC
svn commit: r170887 - /spamassassin/trunk/spamc/spamc.c
Author: jm
Date: Thu May 19 00:17:05 2005
New Revision: 170887
URL: http://svn.apache.org/viewcvs?rev=170887&view=rev
Log:
bug 4335: remove error message if spamc cannot find a config file
Modified:
spamassassin/trunk/spamc/spamc.c
Modified: spamassassin/trunk/spamc/spamc.c
URL: http://svn.apache.org/viewcvs/spamassassin/trunk/spamc/spamc.c?rev=170887&r1=170886&r2=170887&view=diff
==============================================================================
--- spamassassin/trunk/spamc/spamc.c (original)
+++ spamassassin/trunk/spamc/spamc.c Thu May 19 00:17:05 2005
@@ -474,8 +474,6 @@
}
if((config = fopen(config_file, "r")) == NULL) {
- libspamc_log(flags, LOG_ERR,
- "Cannot open %s : %s", config_file, strerror(errno));
return EX_CONFIG;
}
Re: svn commit: r170887 - /spamassassin/trunk/spamc/spamc.c
Posted by John Madden <ma...@skynet.ie>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On (21/05/05 11:04), Michael Parker didst pronounce:
> > if((config = fopen(config_file, "r")) == NULL) {
> > - libspamc_log(flags, LOG_ERR,
> > - "Cannot open %s : %s", config_file, strerror(errno));
> > return EX_CONFIG;
> > }
>
> What about the case where the user specified which config file to use
> via -F <someconfig> and it is missing? Now we get no error.
>
Hmm. It shouldn't be logged via syslog anyway, because it logs to
mail.log and that's generally not readable by users, meaning the message
would be no good for the user. A note to stderr would be a better
option for a user specified config. It'd be easy enough to implement, if
it's wanted.
- --
Chat ya later,
John.
- --
BOFH excuse #1: clock speed
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
iD8DBQFCj2RPQBw+ZtKOvTIRAq1AAJ99l6ZlU3qNros3TwzFs4t0h70OcwCePhHR
cfXsFceXjGeJ/cx1G5+kcK0=
=2y1R
-----END PGP SIGNATURE-----
Re: svn commit: r170887 - /spamassassin/trunk/spamc/spamc.c
Posted by Michael Parker <pa...@pobox.com>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
jm@apache.org wrote:
> Author: jm
> Date: Thu May 19 00:17:05 2005
> New Revision: 170887
>
> URL: http://svn.apache.org/viewcvs?rev=170887&view=rev
> Log:
> bug 4335: remove error message if spamc cannot find a config file
>
> Modified:
> spamassassin/trunk/spamc/spamc.c
>
> Modified: spamassassin/trunk/spamc/spamc.c
> URL: http://svn.apache.org/viewcvs/spamassassin/trunk/spamc/spamc.c?rev=170887&r1=170886&r2=170887&view=diff
> ==============================================================================
> --- spamassassin/trunk/spamc/spamc.c (original)
> +++ spamassassin/trunk/spamc/spamc.c Thu May 19 00:17:05 2005
> @@ -474,8 +474,6 @@
> }
>
> if((config = fopen(config_file, "r")) == NULL) {
> - libspamc_log(flags, LOG_ERR,
> - "Cannot open %s : %s", config_file, strerror(errno));
> return EX_CONFIG;
> }
>
>
>
>
What about the case where the user specified which config file to use
via -F <someconfig> and it is missing? Now we get no error.
Michael
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFCj1wcG4km+uS4gOIRAgrwAKCHdN195eISdNx0s9+TtqYkVB3RtwCeKuBU
b8KsBPaQOdiYrkklwDp+56o=
=KBB3
-----END PGP SIGNATURE-----