You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Kyle Bendickson (Jira)" <ji...@apache.org> on 2020/11/04 05:56:00 UTC
[jira] [Comment Edited] (SPARK-33282) Replace Probot Autolabeler
with Github Action
[ https://issues.apache.org/jira/browse/SPARK-33282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225874#comment-17225874 ]
Kyle Bendickson edited comment on SPARK-33282 at 11/4/20, 5:55 AM:
-------------------------------------------------------------------
I've opened a WIP PR for this [~hyukjin.kwon] [~dongjoon]: [https://github.com/apache/spark/pull/30244]
For reference, here's the ticket with ASF Infra to remove the Probot Autolabeler's permissions from the repos: https://issues.apache.org/jira/browse/INFRA-21048.
Infra needs somebody to at least notify the Beam folks so that they can pull the plug on the Probot Autolabeler's read and write permissions across all apache repos. I will reach out to them, but I can't take on migrating their config as it's rather involved and I'm not familiar enough with that project.
I've already taken care of the Iceberg and Avro labelers in https://issues.apache.org/jira/browse/AVRO-2948 and [https://github.com/apache/iceberg/pull/1686.]
I'll also try to follow up with a demo PR to cancel old workflows on PRs that people have pushed to, specifically tests which take a long time and utilize our limited GH action runners, as soon as possible. After looking into it, this is the one that I would use: [https://github.com/marketplace/actions/cancel-workflow-action] [.|https://github.com/marketplace/actions/cancel-all-previous-workflow-runs.] They don't make it super clear, but if you just make that a step at the beginning of the workflow, it should then terminate old workflows on PR push. Likely we need to use something that's `on: pull_request_action` and not `on: pull` as people who don't have write access (i.e. non-committers like me) don't trigger `pull` events from our PRs from forks, but we do trigger `pull_request_action`.
If that action doesn't work, I'd look into this one next: [https://github.com/marketplace/actions/cancel-all-previous-workflow-runs|https://github.com/marketplace/actions/cancel-all-previous-workflow-runs.].
Hopefully coming up I can create an issue for this / reach out on the dev list but I am admittedly somewhat swamped this week. Thanks guys!
was (Author: kbendick):
I've opened a WIP PR for this [~hyukjin.kwon] [~dongjoon]: [https://github.com/apache/spark/pull/30244]
For reference, here's the ticket with ASF Infra to remove the Probot Autolabeler's permissions from the repos: https://issues.apache.org/jira/browse/INFRA-21048.
Infra needs somebody to at least notify the Beam folks so that they can pull the plug on the Probot Autolabeler's read and write permissions across all apache repos. I will reach out to them, but I can't take on migrating their config as it's rather involved and I'm not familiar enough with that project.
I've already taken care of the Iceberg and Avro labelers in https://issues.apache.org/jira/browse/AVRO-2948 and [https://github.com/apache/iceberg/pull/1686.]
I'll also try to follow up with a demo PR to cancel old workflows on PRs that people have pushed to, specifically tests which take a long time and utilize our limited GH action runners, as soon as possible. After looking into it, this is the one that I would use: [https://github.com/marketplace/actions/cancel-workflow-action] [.|https://github.com/marketplace/actions/cancel-all-previous-workflow-runs.] They don't make it super clear, but if you just make that a step at the beginning of the workflow, it should then terminate old workflows on PR push. Likely we need to use something that's `on: pull_request_action` and not `on: pull` as people who don't have write access (i.e. non-committers like me) don't trigger `pull` events from our PRs from forks, but we do trigger `pull_request_action`.
If that action doesn't work, I'd look into this one next: [https://github.com/marketplace/actions/cancel-all-previous-workflow-runs|https://github.com/marketplace/actions/cancel-all-previous-workflow-runs.].
Hopefully coming up I can create an issue for this / reach out on the dev list but I am admittedly somewhat swamped this week. Thanks guys!
cc [~hyukjin.kwon] [~dongjoon]
> Replace Probot Autolabeler with Github Action
> ---------------------------------------------
>
> Key: SPARK-33282
> URL: https://issues.apache.org/jira/browse/SPARK-33282
> Project: Spark
> Issue Type: Task
> Components: Project Infra
> Affects Versions: 3.0.1
> Reporter: Kyle Bendickson
> Priority: Major
>
> The Probot Autolabeler that we were using in both the Iceberg and the Spark repo is no longer working. I've confirmed that with the devleper, github user [at]mithro, who has indicated that the Probot Autolabeler is end of life and will not be maintained moving forward.
> PRs have not been labeled for a few weeks now.
>
> As I'm already interfacing with ASF Infra to have the probot permissions revoked from the Iceberg repo, and I've already submitted a patch to switch Iceberg to the standard github labeler action, I figured I would go ahead and volunteer myself to switch the Spark repo as well.
> I will have a patch to switch to the new github labeler open within a few days.
>
> Also thank you [~blue] (or [~holden]) for shepherding this! I didn't exactly ask, but it was understood in our group meeting for Iceberg that I'd be converting our labeler there so I figured I'd tackle the spark issue while I'm getting my hands into the labeling configs anyway =)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org