You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by "VirtualTim (via GitHub)" <gi...@apache.org> on 2023/03/16 04:45:59 UTC
[GitHub] [tomcat] VirtualTim opened a new pull request, #600: echo the value of %JAVA_HOME% when it is invalid.
VirtualTim opened a new pull request, #600:
URL: https://github.com/apache/tomcat/pull/600
This is useful for diagnosing %JAVA_HOME% issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] VirtualTim commented on pull request #600: echo the value of %JAVA_HOME% when it is invalid.
Posted by "VirtualTim (via GitHub)" <gi...@apache.org>.
VirtualTim commented on PR #600:
URL: https://github.com/apache/tomcat/pull/600#issuecomment-1504514693
Oh cool. I was planning on getting around to it, but didn't get time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #600: echo the value of %JAVA_HOME% when it is invalid.
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #600:
URL: https://github.com/apache/tomcat/pull/600#issuecomment-1503021102
If neither `JRE_HOME` nor `JAVA_HOME` is defined, a message is already shown.
I have undertaken a wider review of setclasspath.bat and service.bat and added additional messages when values aren't valid and aligned the handling of `JRE_HOME` and `JAVA_HOME` for both scripts. There is no functional change but there are additional messages and the code is consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf closed pull request #600: echo the value of %JAVA_HOME% when it is invalid.
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf closed pull request #600: echo the value of %JAVA_HOME% when it is invalid.
URL: https://github.com/apache/tomcat/pull/600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] markt-asf commented on pull request #600: echo the value of %JAVA_HOME% when it is invalid.
Posted by "markt-asf (via GitHub)" <gi...@apache.org>.
markt-asf commented on PR #600:
URL: https://github.com/apache/tomcat/pull/600#issuecomment-1504867534
np - thanks for the prompt to improve things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[GitHub] [tomcat] PasunuriSrinidhi commented on pull request #600: echo the value of %JAVA_HOME% when it is invalid.
Posted by "PasunuriSrinidhi (via GitHub)" <gi...@apache.org>.
PasunuriSrinidhi commented on PR #600:
URL: https://github.com/apache/tomcat/pull/600#issuecomment-1484093801
if not "%JAVA_HOME%" == "" (
set "JAVA="%JAVA_HOME%\bin\java.exe""
) else (
echo The JAVA_HOME environment variable is not defined correctly.
echo JAVA_HOME="%JAVA_HOME%"
)
This way, if JAVA_HOME is not defined, the user will see a clear message stating that the variable is not defined correctly, and the value of the variable (which will be empty in this case) will be echoed back for reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org