Re: [PR] Add missing "overrides" to realm-override config examples & tests [polaris]

["adutra (via GitHub)" <gi...@apache.org>]

adutra commented on PR #1511:
URL: https://github.com/apache/polaris/pull/1511#issuecomment-2847776679

   @RichardLiu2001 sorry I approved too soon :-)
   
   There are two issues here:
   
   1. You spotted a bug in the configmap generation where we were using `polaris.config` instead of `polaris.features`. I think it's legit to fix that.
   2. You spotted that the work `.overrides.` is missing in `polaris.features.realm-overrides."my-realm".overrides."feature"=true` – true, but I think the error is in `FeaturesConfiguration.RealmOverrides`: the `RealmOverrides#overrides` method should have been annotated with `@WithParentName`.
   
   For 2, it's a regression introduced by b93e97b9c5c97cb813696df50aee7550f21b155c. @eric-maynard was your change intentional, that is, you want the word `.overrides.` to appear in the configuration, or is it OK to revert the changes to `QuarkusFeaturesConfiguration`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org