[Impala-ASF-CR] WIP IMPALA-11629: Support for huawei OBS FileSystem

["Anonymous Coward (Code Review)" <ge...@cloudera.org>]

lipenglin@sensorsdata.cn has posted comments on this change. ( http://gerrit.cloudera.org:8080/19110 )

Change subject: WIP IMPALA-11629: Support for huawei OBS FileSystem
......................................................................


Patch Set 5:

(2 comments)

LGTM. Left some minor comments.

http://gerrit.cloudera.org:8080/#/c/19110/5/be/src/runtime/io/disk-io-mgr.cc
File be/src/runtime/io/disk-io-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/19110/5/be/src/runtime/io/disk-io-mgr.cc@148
PS5, Line 148: 16
If this is not an empirical value, we can add a comment: 'TODO: choose the default empirically.'


http://gerrit.cloudera.org:8080/#/c/19110/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
File fe/src/main/java/org/apache/impala/common/FileSystemUtil.java:

http://gerrit.cloudera.org:8080/#/c/19110/5/fe/src/main/java/org/apache/impala/common/FileSystemUtil.java@458
PS5, Line 458: iff
nit: if
We should also change the 'iff' -> 'if' in the comments above.



-- 
To view, visit http://gerrit.cloudera.org:8080/19110
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I84a54dbebcc5b71e9bcdd141dae9e95104d98cb1
Gerrit-Change-Number: 19110
Gerrit-PatchSet: 5
Gerrit-Owner: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Xiang Yang <yx...@126.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Dec 2022 03:19:17 +0000
Gerrit-HasComments: Yes