You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by pa...@apache.org on 2018/12/27 20:15:12 UTC
[groovy] branch master updated (5fd6c31 -> febddb7)
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git.
from 5fd6c31 cleanup/remove @author tags as per Apache recommended practices for groovy-groovysh, groovy-macro
new c4aa669 Fix typos (closes #842)
new febddb7 cleanup/remove @author tags as per Apache recommended practices for groovy-servlet, groovy-sql
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
gradle/pomconfigurer.gradle | 12 ++++++++++++
src/spec/doc/design-pattern-composite.adoc | 2 +-
src/test/groovy/bugs/ByteIndexBug.groovy | 3 ---
src/test/org/codehaus/groovy/dummy/FooHandler.java | 3 ---
subprojects/groovy-jmx/src/spec/doc/jmx.adoc | 4 ++--
.../src/main/java/groovy/servlet/AbstractHttpServlet.java | 3 ---
.../src/main/java/groovy/servlet/GroovyServlet.java | 6 ------
.../src/main/java/groovy/servlet/ServletBinding.java | 8 --------
.../src/main/java/groovy/servlet/TemplateServlet.java | 4 ----
.../groovy/groovy/servlet/AbstractHttpServletTest.groovy | 2 --
.../src/test/groovy/groovy/servlet/ServletBindingTest.groovy | 2 --
.../java/groovy/sql/BatchingPreparedStatementWrapper.java | 3 ---
.../groovy-sql/src/main/java/groovy/sql/CallResultSet.java | 2 --
subprojects/groovy-sql/src/main/java/groovy/sql/DataSet.java | 4 ----
.../src/main/java/groovy/sql/ExpandedVariable.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/GroovyResultSet.java | 4 ----
.../src/main/java/groovy/sql/GroovyResultSetExtension.java | 1 -
.../src/main/java/groovy/sql/GroovyResultSetProxy.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/GroovyRowResult.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/InOutParameter.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/InParameter.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/OutParameter.java | 2 --
.../src/main/java/groovy/sql/ResultSetOutParameter.java | 2 --
subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java | 10 ----------
.../src/main/java/groovy/sql/SqlOrderByVisitor.java | 4 ----
.../groovy-sql/src/main/java/groovy/sql/SqlWhereVisitor.java | 3 ---
.../src/test/groovy/groovy/bugs/ForAndSqlBug.groovy | 3 ---
.../src/test/groovy/groovy/sql/SqlBatchTest.groovy | 2 --
.../src/test/groovy/groovy/sql/SqlCacheTest.groovy | 2 --
.../groovy-sql/src/test/groovy/groovy/sql/SqlCallTest.groovy | 2 --
.../src/test/groovy/groovy/sql/SqlStatementTest.groovy | 2 --
.../groovy/groovy/sql/SqlTransactionConnectionTest.groovy | 2 --
.../groovy/groovy/sql/SqlTransactionDataSourceTest.groovy | 2 --
.../src/test/groovy/groovy/sql/SqlTransactionTestCase.groovy | 2 --
.../src/test/groovy/groovy/sql/SqlWithBuilderTest.groovy | 3 ---
.../test/groovy/groovy/sql/SqlWithTypedResultsTest.groovy | 4 ----
36 files changed, 15 insertions(+), 103 deletions(-)
[groovy] 02/02: cleanup/remove @author tags as per Apache
recommended practices for groovy-servlet, groovy-sql
Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git
commit febddb741f1ddb7b4df847f8688a6bd3274d3b4a
Author: Paul King <pa...@asert.com.au>
AuthorDate: Fri Dec 28 06:14:59 2018 +1000
cleanup/remove @author tags as per Apache recommended practices for groovy-servlet, groovy-sql
---
gradle/pomconfigurer.gradle | 12 ++++++++++++
src/test/groovy/bugs/ByteIndexBug.groovy | 3 ---
src/test/org/codehaus/groovy/dummy/FooHandler.java | 3 ---
.../src/main/java/groovy/servlet/AbstractHttpServlet.java | 3 ---
.../src/main/java/groovy/servlet/GroovyServlet.java | 6 ------
.../src/main/java/groovy/servlet/ServletBinding.java | 8 --------
.../src/main/java/groovy/servlet/TemplateServlet.java | 4 ----
.../groovy/groovy/servlet/AbstractHttpServletTest.groovy | 2 --
.../src/test/groovy/groovy/servlet/ServletBindingTest.groovy | 2 --
.../java/groovy/sql/BatchingPreparedStatementWrapper.java | 3 ---
.../groovy-sql/src/main/java/groovy/sql/CallResultSet.java | 2 --
subprojects/groovy-sql/src/main/java/groovy/sql/DataSet.java | 4 ----
.../src/main/java/groovy/sql/ExpandedVariable.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/GroovyResultSet.java | 4 ----
.../src/main/java/groovy/sql/GroovyResultSetExtension.java | 1 -
.../src/main/java/groovy/sql/GroovyResultSetProxy.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/GroovyRowResult.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/InOutParameter.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/InParameter.java | 2 --
.../groovy-sql/src/main/java/groovy/sql/OutParameter.java | 2 --
.../src/main/java/groovy/sql/ResultSetOutParameter.java | 2 --
subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java | 10 ----------
.../src/main/java/groovy/sql/SqlOrderByVisitor.java | 4 ----
.../groovy-sql/src/main/java/groovy/sql/SqlWhereVisitor.java | 3 ---
.../src/test/groovy/groovy/bugs/ForAndSqlBug.groovy | 3 ---
.../src/test/groovy/groovy/sql/SqlBatchTest.groovy | 2 --
.../src/test/groovy/groovy/sql/SqlCacheTest.groovy | 2 --
.../groovy-sql/src/test/groovy/groovy/sql/SqlCallTest.groovy | 2 --
.../src/test/groovy/groovy/sql/SqlStatementTest.groovy | 2 --
.../groovy/groovy/sql/SqlTransactionConnectionTest.groovy | 2 --
.../groovy/groovy/sql/SqlTransactionDataSourceTest.groovy | 2 --
.../src/test/groovy/groovy/sql/SqlTransactionTestCase.groovy | 2 --
.../src/test/groovy/groovy/sql/SqlWithBuilderTest.groovy | 3 ---
.../test/groovy/groovy/sql/SqlWithTypedResultsTest.groovy | 4 ----
34 files changed, 12 insertions(+), 100 deletions(-)
diff --git a/gradle/pomconfigurer.gradle b/gradle/pomconfigurer.gradle
index ee72aa5..cc3fb90 100644
--- a/gradle/pomconfigurer.gradle
+++ b/gradle/pomconfigurer.gradle
@@ -639,6 +639,18 @@ project.ext.pomConfigureClosureWithoutTweaks = {
name 'Marty Saxton'
}
contributor {
+ name 'Marcel Overdijk'
+ }
+ contributor {
+ name 'Jonathan Carlson'
+ }
+ contributor {
+ name 'Thomas Heller'
+ }
+ contributor {
+ name 'Ivan Ganza'
+ }
+ contributor {
name 'Alex Popescu'
}
contributor {
diff --git a/src/test/groovy/bugs/ByteIndexBug.groovy b/src/test/groovy/bugs/ByteIndexBug.groovy
index bb4825f..906882e 100644
--- a/src/test/groovy/bugs/ByteIndexBug.groovy
+++ b/src/test/groovy/bugs/ByteIndexBug.groovy
@@ -18,9 +18,6 @@
*/
package groovy.bugs
-/**
- * @author Robert Fuller
- */
class ByteIndexBug extends GroovyTestCase {
// TODO: this tests a string with 128 nulls - is that what is intended?
void testBug() {
diff --git a/src/test/org/codehaus/groovy/dummy/FooHandler.java b/src/test/org/codehaus/groovy/dummy/FooHandler.java
index 7a0f7ba..704ab96 100644
--- a/src/test/org/codehaus/groovy/dummy/FooHandler.java
+++ b/src/test/org/codehaus/groovy/dummy/FooHandler.java
@@ -20,9 +20,6 @@ package org.codehaus.groovy.dummy;
import java.io.Reader;
-/**
- * @author Robert Fuller
- */
public interface FooHandler {
void handle(Reader reader);
}
diff --git a/subprojects/groovy-servlet/src/main/java/groovy/servlet/AbstractHttpServlet.java b/subprojects/groovy-servlet/src/main/java/groovy/servlet/AbstractHttpServlet.java
index 7a2d615..fecb97b 100644
--- a/subprojects/groovy-servlet/src/main/java/groovy/servlet/AbstractHttpServlet.java
+++ b/subprojects/groovy-servlet/src/main/java/groovy/servlet/AbstractHttpServlet.java
@@ -78,9 +78,6 @@ import java.util.regex.Pattern;
* <pre>
* reflection = false(default) | true
* </pre>
- *
- * @author Christian Stein
- * @author Roshan Dawrani (roshandawrani)
*/
public abstract class AbstractHttpServlet extends HttpServlet implements ResourceConnector {
diff --git a/subprojects/groovy-servlet/src/main/java/groovy/servlet/GroovyServlet.java b/subprojects/groovy-servlet/src/main/java/groovy/servlet/GroovyServlet.java
index f64ec95..73b044d 100644
--- a/subprojects/groovy-servlet/src/main/java/groovy/servlet/GroovyServlet.java
+++ b/subprojects/groovy-servlet/src/main/java/groovy/servlet/GroovyServlet.java
@@ -67,12 +67,6 @@ import java.io.IOException;
* <p>The URL pattern does not require the "*.groovy" mapping. You can, for
* example, make it more Struts-like but groovy by making your mapping "*.gdo".
*
- * @author Sam Pullara
- * @author Mark Turansky (markturansky at hotmail.com)
- * @author Guillaume Laforge
- * @author Christian Stein
- * @author Marcel Overdijk
- *
* @see groovy.servlet.ServletBinding
*/
public class GroovyServlet extends AbstractHttpServlet {
diff --git a/subprojects/groovy-servlet/src/main/java/groovy/servlet/ServletBinding.java b/subprojects/groovy-servlet/src/main/java/groovy/servlet/ServletBinding.java
index 3b386f9..b626969 100644
--- a/subprojects/groovy-servlet/src/main/java/groovy/servlet/ServletBinding.java
+++ b/subprojects/groovy-servlet/src/main/java/groovy/servlet/ServletBinding.java
@@ -92,18 +92,12 @@ import java.util.Map;
* <li><tt>"include(String path)"</tt> : <code>request.getRequestDispatcher(path).include(request, response)</code></li>
* <li><tt>"redirect(String location)"</tt> : <code>response.sendRedirect(location)</code></li>
* </ul>
- *
- * @author Guillaume Laforge
- * @author Christian Stein
- * @author Jochen Theodorou
*/
public class ServletBinding extends Binding {
/**
* A OutputStream dummy that will throw a GroovyBugError for any
* write method call to it.
- *
- * @author Jochen Theodorou
*/
private static class InvalidOutputStream extends OutputStream {
/**
@@ -121,8 +115,6 @@ public class ServletBinding extends Binding {
* using the stream will cause a IllegalStateException. 'used' means
* any write method has been called. Simply requesting the objects will
* not cause an exception.
- *
- * @author Jochen Theodorou
*/
private static class ServletOutput {
private final HttpServletResponse response;
diff --git a/subprojects/groovy-servlet/src/main/java/groovy/servlet/TemplateServlet.java b/subprojects/groovy-servlet/src/main/java/groovy/servlet/TemplateServlet.java
index d64378e..ba43617 100644
--- a/subprojects/groovy-servlet/src/main/java/groovy/servlet/TemplateServlet.java
+++ b/subprojects/groovy-servlet/src/main/java/groovy/servlet/TemplateServlet.java
@@ -102,8 +102,6 @@ import java.util.WeakHashMap;
* groovy.source.encoding
* </pre>
*
- * @author Christian Stein
- * @author Guillaume Laforge
* @see TemplateServlet#setVariables(ServletBinding)
*/
public class TemplateServlet extends AbstractHttpServlet {
@@ -111,8 +109,6 @@ public class TemplateServlet extends AbstractHttpServlet {
/**
* Simple cache entry. If a file is supplied, then the entry is validated against
* last modified and length attributes of the specified file.
- *
- * @author Christian Stein
*/
private static class TemplateCacheEntry {
diff --git a/subprojects/groovy-servlet/src/test/groovy/groovy/servlet/AbstractHttpServletTest.groovy b/subprojects/groovy-servlet/src/test/groovy/groovy/servlet/AbstractHttpServletTest.groovy
index 8f6a4ed..1b7fb9f 100644
--- a/subprojects/groovy-servlet/src/test/groovy/groovy/servlet/AbstractHttpServletTest.groovy
+++ b/subprojects/groovy-servlet/src/test/groovy/groovy/servlet/AbstractHttpServletTest.groovy
@@ -26,8 +26,6 @@ import javax.servlet.ServletConfig
* This test case tests the AbstractHttpServlet class. It uses a test
* specific subclass called ConcreteHttpServlet to test the abstract
* class in isolation from any implementations.
- *
- * @author Hamlet D'Arcy
*/
class AbstractHttpServletTest extends GroovyTestCase {
diff --git a/subprojects/groovy-servlet/src/test/groovy/groovy/servlet/ServletBindingTest.groovy b/subprojects/groovy-servlet/src/test/groovy/groovy/servlet/ServletBindingTest.groovy
index 4100b12..138df07 100644
--- a/subprojects/groovy-servlet/src/test/groovy/groovy/servlet/ServletBindingTest.groovy
+++ b/subprojects/groovy-servlet/src/test/groovy/groovy/servlet/ServletBindingTest.groovy
@@ -27,8 +27,6 @@ import groovy.xml.MarkupBuilder
/**
* This test case tests the ServletBinding class.
- *
- * @author Hamlet D'Arcy
*/
class ServletBindingTest extends GroovyTestCase {
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/BatchingPreparedStatementWrapper.java b/subprojects/groovy-sql/src/main/java/groovy/sql/BatchingPreparedStatementWrapper.java
index eb8d76c..6f02420 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/BatchingPreparedStatementWrapper.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/BatchingPreparedStatementWrapper.java
@@ -31,9 +31,6 @@ import java.util.logging.Logger;
* a batch count size. If the batch count reaches the predefined number,
* this Statement does an executeBatch() automatically. If batchSize is
* zero, then no batching is performed.
- *
- * @author Daniel Henrique Alves Lima
- * @author Paul King
*/
public class BatchingPreparedStatementWrapper extends BatchingStatementWrapper {
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/CallResultSet.java b/subprojects/groovy-sql/src/main/java/groovy/sql/CallResultSet.java
index a821d78..3b7a807 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/CallResultSet.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/CallResultSet.java
@@ -24,8 +24,6 @@ import java.sql.SQLException;
/**
* Represents a ResultSet retrieved as a callable statement out parameter.
- *
- * @author rfuller
*/
class CallResultSet extends GroovyResultSetExtension {
int indx;
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/DataSet.java b/subprojects/groovy-sql/src/main/java/groovy/sql/DataSet.java
index 551a349..7d3c922 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/DataSet.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/DataSet.java
@@ -65,10 +65,6 @@ import java.util.Set;
* classpath at runtime. Also, at the moment, the expressions (or nested expressions) can only contain
* references to fields of the POGO or literals (i.e. constant Strings or numbers). This limitation
* may be removed in a future version of Groovy.
- *
- * @author Chris Stevenson
- * @author Paul King
- * @author <a href="mailto:james@coredevelopers.net">James Strachan</a>
*/
public class DataSet extends Sql {
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/ExpandedVariable.java b/subprojects/groovy-sql/src/main/java/groovy/sql/ExpandedVariable.java
index 9fdbeed..1ad1957 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/ExpandedVariable.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/ExpandedVariable.java
@@ -21,8 +21,6 @@ package groovy.sql;
/**
* Identifies a variable to be expanded into the
* sql string rather than representing a placeholder.
- *
- * @author rfuller
*/
public interface ExpandedVariable {
Object getObject();
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSet.java b/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSet.java
index ef5d135..6a1cea8 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSet.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSet.java
@@ -27,10 +27,6 @@ import java.util.Map;
/**
* Represents an extent of objects
- *
- * @author <a href="mailto:james@coredevelopers.net">James Strachan</a>
- * @author <a href="mailto:ivan_ganza@yahoo.com">Ivan Ganza</a>
- * @author Chris Stevenson
*/
public interface GroovyResultSet extends GroovyObject, ResultSet {
/**
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSetExtension.java b/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSetExtension.java
index e7eeda2..759d13c 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSetExtension.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSetExtension.java
@@ -40,7 +40,6 @@ import java.util.Map;
* <b>This class is not intended to be used directly. Should be used through
* GroovyResultSetProxy only!</b>
*
- * @author Jochen Theodorou
* @see GroovyResultSet
* @see GroovyResultSetProxy
*/
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSetProxy.java b/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSetProxy.java
index 2e242d7..39764be 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSetProxy.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyResultSetProxy.java
@@ -37,8 +37,6 @@ import java.sql.ResultSet;
* This way it is possible to replace and add methods. To overload methods
* from ResultSet all methods have to be implemented on the extension
* class.
- *
- * @author Jochen Theodorou
*/
public final class GroovyResultSetProxy implements InvocationHandler {
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyRowResult.java b/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyRowResult.java
index 00224bf..4202749 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyRowResult.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/GroovyRowResult.java
@@ -30,8 +30,6 @@ import java.util.Set;
* Represents an extent of objects.
* It's primarily used by methods of Groovy's {@link groovy.sql.Sql} class to return {@code ResultSet} data in map
* form; allowing access to the result of a SQL query by the name of the column, or by the column number.
- *
- * @author Jean-Louis Berliet
*/
public class GroovyRowResult extends GroovyObjectSupport implements Map {
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/InOutParameter.java b/subprojects/groovy-sql/src/main/java/groovy/sql/InOutParameter.java
index 3f00ca4..cdfcc82 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/InOutParameter.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/InOutParameter.java
@@ -19,8 +19,6 @@
package groovy.sql;
/**
- * @author rfuller
- *
* A typed parameter passed to, and returned from a CallableStatement.
*/
public interface InOutParameter extends InParameter, OutParameter {
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/InParameter.java b/subprojects/groovy-sql/src/main/java/groovy/sql/InParameter.java
index 49eea9b..02880f2 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/InParameter.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/InParameter.java
@@ -20,8 +20,6 @@ package groovy.sql;
/**
* A typed parameter to pass to a query
- *
- * @author rfuller
*/
public interface InParameter {
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/OutParameter.java b/subprojects/groovy-sql/src/main/java/groovy/sql/OutParameter.java
index 34c9eb8..8e41927 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/OutParameter.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/OutParameter.java
@@ -20,8 +20,6 @@ package groovy.sql;
/**
* A parameter to be returned from a CallableStatement.
- *
- * @author rfuller
*/
public interface OutParameter {
/**
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/ResultSetOutParameter.java b/subprojects/groovy-sql/src/main/java/groovy/sql/ResultSetOutParameter.java
index a2a68a8..4f59f2e 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/ResultSetOutParameter.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/ResultSetOutParameter.java
@@ -20,8 +20,6 @@ package groovy.sql;
/**
* A ResultSet out parameter.
- * @author rfuller
- *
*/
public interface ResultSetOutParameter extends OutParameter{
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java b/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java
index 1616f65..513bc0e 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/Sql.java
@@ -229,16 +229,6 @@ import static org.apache.groovy.sql.extensions.SqlExtensions.toRowResult;
* the interaction with the underlying database.
* <p>
* This class is <b>not</b> thread-safe.
- *
- * @author Chris Stevenson
- * @author <a href="mailto:james@coredevelopers.net">James Strachan</a>
- * @author Paul King
- * @author Marc DeXeT
- * @author John Bito
- * @author John Hurst
- * @author David Durham
- * @author Daniel Henrique Alves Lima
- * @author David Sutherland
*/
public class Sql implements AutoCloseable {
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/SqlOrderByVisitor.java b/subprojects/groovy-sql/src/main/java/groovy/sql/SqlOrderByVisitor.java
index de6c0b2..62d0345 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/SqlOrderByVisitor.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/SqlOrderByVisitor.java
@@ -22,9 +22,6 @@ import org.codehaus.groovy.ast.CodeVisitorSupport;
import org.codehaus.groovy.ast.expr.PropertyExpression;
import org.codehaus.groovy.ast.stmt.ReturnStatement;
-/**
- * @author Paul King
- */
public class SqlOrderByVisitor extends CodeVisitorSupport {
private final StringBuffer buffer = new StringBuffer();
@@ -41,5 +38,4 @@ public class SqlOrderByVisitor extends CodeVisitorSupport {
buffer.append(expression.getPropertyAsString());
}
-
}
diff --git a/subprojects/groovy-sql/src/main/java/groovy/sql/SqlWhereVisitor.java b/subprojects/groovy-sql/src/main/java/groovy/sql/SqlWhereVisitor.java
index f994cae..76cca95 100644
--- a/subprojects/groovy-sql/src/main/java/groovy/sql/SqlWhereVisitor.java
+++ b/subprojects/groovy-sql/src/main/java/groovy/sql/SqlWhereVisitor.java
@@ -33,9 +33,6 @@ import org.codehaus.groovy.syntax.Types;
import java.util.ArrayList;
import java.util.List;
-/**
- * @author James Strachan
- */
public class SqlWhereVisitor extends CodeVisitorSupport {
private final StringBuffer buffer = new StringBuffer();
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/bugs/ForAndSqlBug.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/bugs/ForAndSqlBug.groovy
index 3e9e240..1141b28 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/bugs/ForAndSqlBug.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/bugs/ForAndSqlBug.groovy
@@ -20,9 +20,6 @@ package groovy.bugs
import groovy.sql.SqlHelperTestCase
-/**
- * @author Jonathan Carlson
- */
class ForAndSqlBug extends GroovyTestCase {
void testBugInNormalMethod() {
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlBatchTest.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlBatchTest.groovy
index 6916113..72e8e60 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlBatchTest.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlBatchTest.groovy
@@ -26,8 +26,6 @@ import static groovy.sql.SqlTestConstants.*
/**
* Test Sql batch features
- *
- * @author Paul King
*/
class SqlBatchTest extends GroovyTestCase {
Sql sql
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlCacheTest.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlCacheTest.groovy
index 52e0941..213ba57 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlCacheTest.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlCacheTest.groovy
@@ -27,8 +27,6 @@ import static groovy.sql.SqlTestConstants.*
/**
* Unit test of Sql cache feature
- * @author Marc DeXeT
- * @author Paul King
*/
class SqlCacheTest extends GroovyTestCase {
Sql sql
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlCallTest.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlCallTest.groovy
index 8dc6189..cc9ddef 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlCallTest.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlCallTest.groovy
@@ -26,8 +26,6 @@ import static groovy.sql.SqlTestConstants.*
/**
* Test Sql transaction features using a Sql built from a connection
* along with testing Stored Procedure calls
- *
- * @author Paul King
*/
class SqlCallTest extends GroovyTestCase {
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlStatementTest.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlStatementTest.groovy
index 31e9df9..d1720dd 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlStatementTest.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlStatementTest.groovy
@@ -24,8 +24,6 @@ import static groovy.sql.SqlTestConstants.*
/**
* Unit test of Sql statement feature
- *
- * @author Paul King
*/
class SqlStatementTest extends GroovyTestCase {
Sql sql
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionConnectionTest.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionConnectionTest.groovy
index 9a0d2d4..191fe47 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionConnectionTest.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionConnectionTest.groovy
@@ -24,8 +24,6 @@ import static groovy.sql.SqlTestConstants.*
/**
* Test Sql transaction features using a Sql built from a connection
- *
- * @author Paul King
*/
class SqlTransactionConnectionTest extends SqlTransactionTestCase {
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionDataSourceTest.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionDataSourceTest.groovy
index 8e74dd3..2daee04 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionDataSourceTest.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionDataSourceTest.groovy
@@ -24,8 +24,6 @@ import static groovy.sql.SqlTestConstants.*
/**
* Test Sql transaction features using a Sql built from a DataSource
- *
- * @author Paul King
*/
class SqlTransactionDataSourceTest extends SqlTransactionTestCase {
protected Sql setUpSql() {
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionTestCase.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionTestCase.groovy
index 5ae948c..64e5adc 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionTestCase.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlTransactionTestCase.groovy
@@ -23,8 +23,6 @@ import java.sql.SQLException
/**
* Test Sql transaction features using a Sql built from a connection
- *
- * @author Paul King
*/
class SqlTransactionTestCase extends GroovyTestCase {
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlWithBuilderTest.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlWithBuilderTest.groovy
index 21a667c..cbf43ad 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlWithBuilderTest.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlWithBuilderTest.groovy
@@ -18,9 +18,6 @@
*/
package groovy.sql
-/**
- * @author Brian McCallister
- */
class SqlWithBuilderTest extends SqlHelperTestCase {
void testSqlQuery() {
def sql = createSql()
diff --git a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlWithTypedResultsTest.groovy b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlWithTypedResultsTest.groovy
index a9b9feb..e321e18 100644
--- a/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlWithTypedResultsTest.groovy
+++ b/subprojects/groovy-sql/src/test/groovy/groovy/sql/SqlWithTypedResultsTest.groovy
@@ -18,10 +18,6 @@
*/
package groovy.sql
-/**
- * @author Thomas Heller
- * @author Paul King
- */
class SqlWithTypedResultsTest extends SqlHelperTestCase {
void testSqlQuery() {
[groovy] 01/02: Fix typos (closes #842)
Posted by pa...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
paulk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git
commit c4aa66935f2e44ff7b46a04c27d3ed2c07706aca
Author: Javier S. López <js...@gmail.com>
AuthorDate: Sun Dec 16 12:29:37 2018 +0100
Fix typos (closes #842)
---
src/spec/doc/design-pattern-composite.adoc | 2 +-
subprojects/groovy-jmx/src/spec/doc/jmx.adoc | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/spec/doc/design-pattern-composite.adoc b/src/spec/doc/design-pattern-composite.adoc
index e307431..32ce50e 100644
--- a/src/spec/doc/design-pattern-composite.adoc
+++ b/src/spec/doc/design-pattern-composite.adoc
@@ -29,7 +29,7 @@ Consider this usage of the composite pattern where we want to call `toString()`
image::assets/img/CompositeClasses.gif[]
-In Java, the `Component` class is essential as it provides the type used for both leaf and composite nodes. In Groovy, because of duck-typing, we don't need it for that purpose, however, it can still server as a useful place to place common behaviour between the leaf and composite nodes.
+In Java, the `Component` class is essential as it provides the type used for both leaf and composite nodes. In Groovy, because of duck-typing, we don't need it for that purpose, however, it can still serve as a useful place to place common behaviour between the leaf and composite nodes.
For our purposes, we will assemble the following hierarchy of components.
diff --git a/subprojects/groovy-jmx/src/spec/doc/jmx.adoc b/subprojects/groovy-jmx/src/spec/doc/jmx.adoc
index 5c748c6..935e33a 100644
--- a/subprojects/groovy-jmx/src/spec/doc/jmx.adoc
+++ b/subprojects/groovy-jmx/src/spec/doc/jmx.adoc
@@ -712,7 +712,7 @@ JmxBuilder **supports the explicit description and export of constructors** defi
==== Export all Constructors with "*"
-You can use the builder's special '""' **notation to *export all constructors** declared on the underlying bean. The builder will use default values to describe the MBean constructors.
+You can use the builder's special "*" **notation to export all constructors** declared on the underlying bean. The builder will use default values to describe the MBean constructors.
[source,groovy]
----
@@ -747,7 +747,7 @@ Similar to constructors, JmxBuilder supports the description and export of MBean
==== Export All Operations with "*"
-You can use the builder's special '""'' **notation to *export all operations** defined on the bean to be exposed for management. The builder will use default descriptor values for the operations being exported.
+You can use the builder's special "*" **notation to export all operations** defined on the bean to be exposed for management. The builder will use default descriptor values for the operations being exported.
[source,groovy]
----