[jira] [Commented] (SLING-5815) Expose DistributionContentSerializer

["Marius Petria (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-5815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364905#comment-15364905 ] 

Marius Petria commented on SLING-5815:
--------------------------------------

I agree that the DistributionRequest should not be passed to the serializer. Some notes on the patch:
1. I think the RR should still be part of the signature and not wrapped in an object
2. I am a bit concerned about the path expanding that happens when you want to pass only simple paths to the serializer. For a request that contains {{+/content/a/.*}} it will have to traverse the entire subtree and potentially create a very big list of paths which will end up in the filter.xml. Maybe we can define a export structure that contains the minimized information without requiring to traverse the tree before passing it to serializer: an ExportFilter that contains a set of TreeFilter, each TreeFilter contains a root path and two lists of excluded and included PathFilters. So basically passing down to the serializer the responsibility of decoding the filters. Of course we can have an utility method (maybe even exposed in API) that can take an ExportFilter and produce a list of paths, and that can be used by Kryo and Avro.


[1] https://jackrabbit.apache.org/filevault/apidocs/org/apache/jackrabbit/vault/fs/api/FilterSet.html

> Expose DistributionContentSerializer 
> -------------------------------------
>
>                 Key: SLING-5815
>                 URL: https://issues.apache.org/jira/browse/SLING-5815
>             Project: Sling
>          Issue Type: Improvement
>          Components: Distribution
>            Reporter: Tommaso Teofili
>            Assignee: Tommaso Teofili
>             Fix For: Content Distribution 0.2.0
>
>         Attachments: SLING-5815.0.patch
>
>
> Expose {{DistributionContentSerializer}} API from _org.apache.sling.distribution.core_ in order to allow implementation of custom serialization formats (e.g. Avro and Kryo defined in _org.apache.sling.distribution.extensions_).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)