You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/12/13 06:08:38 UTC
[GitHub] [yunikorn-site] KatLantyss opened a new pull request, #229: [YUNIKORN-1417] Create "archived" section in design docs
KatLantyss opened a new pull request, #229:
URL: https://github.com/apache/yunikorn-site/pull/229
Create "archived" section in design docs.
Fix relative file path in documents.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s closed pull request #229: [YUNIKORN-1417] Create "archived" section in design docs
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #229: [YUNIKORN-1417] Create "archived" section in design docs
URL: https://github.com/apache/yunikorn-site/pull/229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on pull request #229: [YUNIKORN-1417] Create "archived" section in design docs
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on PR #229:
URL: https://github.com/apache/yunikorn-site/pull/229#issuecomment-1347836014
When I build the site using `./local_build.sh run` I see a warning:
```
[WARNING] Docs markdown link couldn't be resolved: (cache_removal.md) in "/yunikorn-site/docs/design/archived/scheduler_core_design.md" for version current
```
Please check that.
I also do not see an _Archived_ or an _Archived Designs_ section under the _Designs_ in the side bar.
While we are doing this push Translation up above Designs to have a better flow. I would expect something like this:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-site] wilfred-s commented on a diff in pull request #229: [YUNIKORN-1417] Create "archived" section in design docs
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on code in PR #229:
URL: https://github.com/apache/yunikorn-site/pull/229#discussion_r1051857411
##########
package.json:
##########
@@ -12,7 +12,7 @@
"dependencies": {
"@docusaurus/core": "2.1.0",
"@docusaurus/preset-classic": "2.1.0",
- "@docusaurus/theme-search-algolia": "2.1.0",
+ "@docusaurus/theme-search-algolia": "^2.2.0",
Review Comment:
nit: will rollback on commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org