[GitHub] [spark] gengliangwang commented on a diff in pull request #39148: [SPARK-41644][CORE][UI] Introducing `ProtobufSerDe` to make other module easy to register `ProtoBufSerializer`

[GitBox <gi...@apache.org>]

gengliangwang commented on code in PR #39148:
URL: https://github.com/apache/spark/pull/39148#discussion_r1054035150


##########
core/src/main/scala/org/apache/spark/status/protobuf/RDDStorageInfoWrapperSerializer.scala:
##########
@@ -23,8 +23,13 @@ import org.apache.spark.status.RDDStorageInfoWrapper
 import org.apache.spark.status.api.v1.{RDDDataDistribution, RDDPartitionInfo, RDDStorageInfo}
 import org.apache.spark.status.protobuf.Utils.getOptional
 
-object RDDStorageInfoWrapperSerializer {
-  def serialize(input: RDDStorageInfoWrapper): Array[Byte] = {
+class RDDStorageInfoWrapperSerializer extends ProtoBufSerDe {
+
+  override val supportClass: Class[_] = classOf[RDDStorageInfoWrapper]
+
+  override def serialize(input: Any): Array[Byte] =
+    serialize(input.asInstanceOf[RDDStorageInfoWrapper])
+  private def serialize(input: RDDStorageInfoWrapper): Array[Byte] = {

Review Comment:
   nit: add one blank line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org