You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/02/16 05:16:33 UTC
[GitHub] [dubbo-go] kzhan opened a new pull request #1057: fix:grpc client request timeout processing
kzhan opened a new pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/contributing.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on a change in pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on a change in pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#discussion_r578429459
##########
File path: protocol/grpc/client.go
##########
@@ -123,3 +134,13 @@ func getInvoker(impl interface{}, conn *grpc.ClientConn) interface{} {
res := method.Call(in)
return res[0].Interface()
}
+
+//client timeout
+func UnaryClientTimeoutInterceptor(timeout time.Duration) grpc.UnaryClientInterceptor {
Review comment:
Why does it start with capital？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] kzhan commented on a change in pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
kzhan commented on a change in pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#discussion_r578947287
##########
File path: protocol/grpc/client.go
##########
@@ -123,3 +134,13 @@ func getInvoker(impl interface{}, conn *grpc.ClientConn) interface{} {
res := method.Call(in)
return res[0].Interface()
}
+
+//client timeout
+func UnaryClientTimeoutInterceptor(timeout time.Duration) grpc.UnaryClientInterceptor {
Review comment:
> I think it is private method for `grpc` package, no need to export
I'm sorry, let me fix that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] kzhan removed a comment on pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
kzhan removed a comment on pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#issuecomment-781842694
> test passed？id timeout valid？
The test passed and is online
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] kzhan commented on pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
kzhan commented on pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#issuecomment-781842694
> test passed？id timeout valid？
The test passed and is online
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] fangyincheng commented on pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#issuecomment-781355678
test passed？id timeout valid？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx edited a comment on pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
zouyx edited a comment on pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#issuecomment-782580835
> > test passed？id timeout valid？
>
> The test passed and is online
You can check it offline.
On MacOS, open command line and run ```make verify``` in root dir.
On Windows install sub-system , like ubuntu then open command line and run ```make verify``` in root dir.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
zouyx commented on pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#issuecomment-782580835
> > test passed？id timeout valid？
>
> The test passed and is online
You can check it offline.
On MacOS, open command line and run ```make verify```.
On Windows install sub-system , like ubuntu then open command line and run ```make verify```.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on a change in pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
zouyx commented on a change in pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#discussion_r578882198
##########
File path: protocol/grpc/client.go
##########
@@ -123,3 +134,13 @@ func getInvoker(impl interface{}, conn *grpc.ClientConn) interface{} {
res := method.Call(in)
return res[0].Interface()
}
+
+//client timeout
+func UnaryClientTimeoutInterceptor(timeout time.Duration) grpc.UnaryClientInterceptor {
Review comment:
I think it is private method for `grpc` package, no need to export
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] kzhan commented on pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
kzhan commented on pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#issuecomment-782642988
> > > test passed？id timeout valid？
> >
> >
> > The test passed and is online
>
> You can check it offline.
> On MacOS, open command line and run `make verify` in root dir.
> On Windows install sub-system like ubuntu, then open command line and run `make verify` in root dir.
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] kzhan commented on pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
kzhan commented on pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#issuecomment-781843193
> test passed？id timeout valid？
The test passed and is online
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] kzhan closed pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
kzhan closed pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx edited a comment on pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
zouyx edited a comment on pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#issuecomment-782580835
> > test passed？id timeout valid？
>
> The test passed and is online
You can check it offline.
On MacOS, open command line and run ```make verify``` in root dir.
On Windows install sub-system like ubuntu, then open command line and run ```make verify``` in root dir.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] kzhan commented on a change in pull request #1057: fix:grpc client request timeout processing
Posted by GitBox <gi...@apache.org>.
kzhan commented on a change in pull request #1057:
URL: https://github.com/apache/dubbo-go/pull/1057#discussion_r578947104
##########
File path: protocol/grpc/client.go
##########
@@ -123,3 +134,13 @@ func getInvoker(impl interface{}, conn *grpc.ClientConn) interface{} {
res := method.Call(in)
return res[0].Interface()
}
+
+//client timeout
+func UnaryClientTimeoutInterceptor(timeout time.Duration) grpc.UnaryClientInterceptor {
Review comment:
I'm sorry, let me fix that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org