You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/04/14 22:01:44 UTC
Review Request 58463: Overwriting Symbolic Links with Files in Copy
Provisioner.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58463/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Bugs: MESOS-6327
https://issues.apache.org/jira/browse/MESOS-6327
Repository: mesos
Description
-------
When a layer overwrites a symbolic link with a regular file, the link
must be removed first, otherwise 'cp' would follow the link and
overwrite the target instead of the link itself.
Diffs
-----
src/slave/containerizer/mesos/provisioner/backends/copy.cpp 584cc6524f81cc1bc231b105507dbfe51fec991d
Diff: https://reviews.apache.org/r/58463/diff/1/
Testing
-------
sudo make check
Manually tested with the following docker image:
https://hub.docker.com/r/anldisr/mesos_layers/ (provided by the reporter)
https://hub.docker.com/r/chhsiao/mycrosslink/ (simplist image to reproduce the same bug)
Thanks,
Chun-Hung Hsiao
Re: Review Request 58463: Overwriting Symbolic Links with Files in
Copy Provisioner.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58463/#review172042
-----------------------------------------------------------
Patch looks great!
Reviews applied: [58408, 58463]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On April 14, 2017, 10:04 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58463/
> -----------------------------------------------------------
>
> (Updated April 14, 2017, 10:04 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-6327
> https://issues.apache.org/jira/browse/MESOS-6327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a layer overwrites a symbolic link with a regular file, the link
> must be removed first, otherwise 'cp' would follow the link and
> overwrite the target instead of the link itself.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/backends/copy.cpp 584cc6524f81cc1bc231b105507dbfe51fec991d
>
>
> Diff: https://reviews.apache.org/r/58463/diff/1/
>
>
> Testing
> -------
>
> sudo make check
>
> Manually tested with the following docker images:
> https://hub.docker.com/r/anldisr/mesos_layers/ (provided by the reporter)
> https://hub.docker.com/r/chhsiao/mycrosslink/ (simplist image to reproduce the same bug)
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 58463: Overwriting Symbolic Links with Files in
Copy Provisioner.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58463/#review172170
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On April 17, 2017, 9:52 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58463/
> -----------------------------------------------------------
>
> (Updated April 17, 2017, 9:52 p.m.)
>
>
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-6327
> https://issues.apache.org/jira/browse/MESOS-6327
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a layer overwrites a symbolic link with a regular file, the link
> must be removed first, otherwise 'cp' would follow the link and
> overwrite the target instead of the link itself.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/provisioner/backends/copy.cpp 584cc6524f81cc1bc231b105507dbfe51fec991d
>
>
> Diff: https://reviews.apache.org/r/58463/diff/2/
>
>
> Testing
> -------
>
> sudo make check
>
> Manually tested with the following docker images:
> https://hub.docker.com/r/anldisr/mesos_layers/ (provided by the reporter)
> https://hub.docker.com/r/chhsiao/mycrosslink/ (simplist image to reproduce the same bug)
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 58463: Overwriting Symbolic Links with Files in
Copy Provisioner.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58463/
-----------------------------------------------------------
(Updated April 17, 2017, 9:52 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Changes
-------
Modified according to revision 4 of 58408.
Bugs: MESOS-6327
https://issues.apache.org/jira/browse/MESOS-6327
Repository: mesos
Description
-------
When a layer overwrites a symbolic link with a regular file, the link
must be removed first, otherwise 'cp' would follow the link and
overwrite the target instead of the link itself.
Diffs (updated)
-----
src/slave/containerizer/mesos/provisioner/backends/copy.cpp 584cc6524f81cc1bc231b105507dbfe51fec991d
Diff: https://reviews.apache.org/r/58463/diff/2/
Changes: https://reviews.apache.org/r/58463/diff/1-2/
Testing
-------
sudo make check
Manually tested with the following docker images:
https://hub.docker.com/r/anldisr/mesos_layers/ (provided by the reporter)
https://hub.docker.com/r/chhsiao/mycrosslink/ (simplist image to reproduce the same bug)
Thanks,
Chun-Hung Hsiao
Re: Review Request 58463: Overwriting Symbolic Links with Files in
Copy Provisioner.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58463/
-----------------------------------------------------------
(Updated April 14, 2017, 10:04 p.m.)
Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
Bugs: MESOS-6327
https://issues.apache.org/jira/browse/MESOS-6327
Repository: mesos
Description
-------
When a layer overwrites a symbolic link with a regular file, the link
must be removed first, otherwise 'cp' would follow the link and
overwrite the target instead of the link itself.
Diffs
-----
src/slave/containerizer/mesos/provisioner/backends/copy.cpp 584cc6524f81cc1bc231b105507dbfe51fec991d
Diff: https://reviews.apache.org/r/58463/diff/1/
Testing (updated)
-------
sudo make check
Manually tested with the following docker images:
https://hub.docker.com/r/anldisr/mesos_layers/ (provided by the reporter)
https://hub.docker.com/r/chhsiao/mycrosslink/ (simplist image to reproduce the same bug)
Thanks,
Chun-Hung Hsiao