[jira] [Commented] (AIRFLOW-4385) Add namespace into pod's yaml

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16823094#comment-16823094 ] 

ASF GitHub Bot commented on AIRFLOW-4385:
-----------------------------------------

nikolayskovpin commented on pull request #5152: [AIRFLOW-4385] Add namespace into pod's yaml
URL: https://github.com/apache/airflow/pull/5152
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4385
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: minor changes
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add namespace into pod's yaml
> -----------------------------
>
>                 Key: AIRFLOW-4385
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4385
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: kubernetes, worker
>            Reporter: Nikolay
>            Assignee: Nikolay
>            Priority: Major
>         Attachments: pods_logs.txt
>
>
> During integration phase between Airflow and VerticalPodAutoscaler (link: [https://github.com/kubernetes/autoscaler/tree/master/vertical-pod-autoscaler]) i stumbled into an issue when VerticalPodAutoscaler library doesn't work for Airflow worker pods. 
> How VerticalPodAutoscaler produces resource recommendations:
> - monitor newly created pods
> - compare newly created pods with existing configuration (compare by label and namespace)
> - provide new recommendations if configuration exists for pod
>  VerticalPodAutoscaler finds all created pods by label, but namespace comparison fails every time. I did some investigation and realise that when airflow calls a kubernetes api, it passes yaml file without +metadata.namespace+ property. Go libraries can deserialise this yaml, but there is no information about namespace.
> Attaching logs from VerticalPodAutoscaler, there you can see how airflow pod was deserialised (namespace is missing). Works for custom pod.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)